DESI EDR Tutorial Notebook with Python 3 Kernel

[Ragadeepika-Pucha]

@rnikutta @stephjuneau @jacquesalice @adambolton - This PR is for the DESI EDR notebook that will work with Python 3 Kernel.

Thanks, Raga

[Ragadeepika-Pucha]

@stephjuneau @jacquesalice @rnikutta @adambolton - updated both Py3 notebook with the above suggestions. Fixed some small things in the DESI kernel notebook.

[stephjuneau]

Thanks @Ragadeepika-Pucha! In my opinion, this is now ready to merge (by @jacquesalice or @rnikutta ?)

[rnikutta]

Taking a look right now...

[Ragadeepika-Pucha]

@stephjuneau @rnikutta @jacquesalice @adambolton

@rnikutta - Thank you for the comments. I have implemented most of them - there are a few things that I did not change, like the query comments and the plotting, to be consistent with the other notebook.

• I included the cell for "Authentication", but it is not required to run the notebook - so, I commented it.
• I did not change the query to "pandas" as well, because that requires changes in the next few cells as well. Cell number 12 was giving wrong result with pandas dataframe.
• Thank you for the suggestion about the bitcheck function - I added another parameter to work with the next steps as well.
• Regarding the randomness of selection of spectra -- the plotting functions are written such that if you modify the ii value, it will still work. I added that as a comment in the cell.
• targetid = int(tsel['targetid'].data[ii]) ## SPARCL accepts only python integers --> When the "int()" is removed and the targetid is given as the data from the table, SPARCL does not work. That is the reason for the comment.

Thank you!

[jacquesalice]

Thanks @Ragadeepika-Pucha ! @rnikutta : can you update your review to Approved so we can merge this pull request? It's currently blocked

[rnikutta]

Great, many thanks @Ragadeepika-Pucha ! Just two small things:

• When one isn't logged in (like I just wasn't), you have to use the Auth cell. But for that to work, authClient must be imported. Could you please change this one line in the Imports cell to be:

  from dl import queryClient as qc, authClient as ac

• You did not take my suggestion / code to use a small plot function, instead of repeating much code. Any reason?

[rnikutta]

Hi @Ragadeepika-Pucha , as we discussed yesterday with @stephjuneau , I've added the authClient import myself, and will merge your PR in a second. Thank you for the NB! In a future PR, we can modify the plotting code to define a small function (as suggested in the conversation above), but then make that change in both the DESI and Py3 kernel versions of the NB. It's definitely not urgent.

[Ragadeepika-Pucha]

@rnikutta Thank you for merging the PR! I will add the plotting function to both the notebooks as soon as I can.