astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 49 forks source link

Remove %%time for Group 3 (13 notebooks) #192

Closed jacquesalice closed 1 year ago

jacquesalice commented 1 year ago

%%time has been removed from the following notebooks:

./04_HowTos/SPARCL/How_to_use_SPARCL.ipynb ./04_HowTos/QueryClient/How_to_query_DESI_EDR_Data.ipynb ./04_HowTos/CrossmatchTables/Examples_using_pre_crossmatched_tables.ipynb ./04_HowTos/CrossmatchTables/How_to_crossmatch_tables.ipynb ./04_HowTos/CrossmatchTables/How_to_use_pre_crossmatched_tables.ipynb ./04_HowTos/FileService/How_to_use_SDSS_Data.ipynb ./04_HowTos/DataReduction/PyrafGMOS/DataReductionPyrafGMOS.ipynb ./04_HowTos/DataReduction/DragonsGMOS/DataReductionDragonsGMOS.ipynb ./05_Contrib/Galactic/DELVE_DR1/DELVE_access_dr1.ipynb ./05_Contrib/Galactic/StellarStreamDESDR1.ipynb ./05_Contrib/LSST_Sim/lsst_sim_SGP_plots.ipynb ./05_Contrib/LSST_Sim/single_and_binary_models.ipynb ./05_Contrib/TimeDomain/LightcurvesPhotometrySearch/LightcurvesPhotometrySearch.ipynb

Assigning @rnikutta and @kareninysimba to review.

rnikutta commented 1 year ago

Hi @jacquesalice , I reviewed your crop of NBs, looks good, approving. (don't merge yet)

One minor and unrelated thing (maybe for a separate PR, or this one, doesn't matter): I think the ipynb and html files for this NB could go in a dedicated new sub-dir:

05_Contrib/Galactic/StellarStreamDESDR1.[ipynb|html]

should go into:

05_Contrib/Galactic/StellarStreamDESDR1/StellarStreamDESDR1.[ipynb|html]

Thanks!

jacquesalice commented 1 year ago

Good catch @kareninysimba thanks! I've updated the 2 notebooks

rnikutta commented 1 year ago

I'll do the same for my batch (on PR #196), later today.