search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
57 stars 48 forks source link

Remove specclient notebooks #201

Closed jacquesalice closed 1 year ago

rnikutta commented 1 year ago

Hi @jacquesalice looks good. Good you please also remove this single, already commented-out line from another NB:

./03_ScienceExamples/EmLineGalaxies/02_EmLineGalaxies_Outliers.ipynb "#from dl import specClient as spec\n",

Then we can merge. Thanks!

jacquesalice commented 1 year ago

@rnikutta done!

rnikutta commented 1 year ago

Hi @jacquesalice , sorry, I misled you accidentally: I don't see the "#from dl import specClient as spec\n" line on master in /03_ScienceExamples/EmLineGalaxies/02_EmLineGalaxies_Outliers.ipynb ; I saw it on David's time_dh branch (which my local clone happened to be on when I did the comparison...

However, your fix re-introduced a %%time thing in this notebook. Can you please clean it / restore it again.

Sorry for the extra work!

jacquesalice commented 1 year ago

Closing the PR because the import specclient line already does not exist in the master version of this notebook.