Example of using gravitational wave data with the ANTARES devkit

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users

BSD 3-Clause "New" or "Revised" License

57 stars 48 forks source link

Example of using gravitational wave data with the ANTARES devkit #214

Closed nesquivelr closed 5 months ago

nesquivelr commented 7 months ago

Hi 👋,

We recently added gravitational wave data in ANTARES and this PR adds a jupyter notebook to show users how to access this data and use these new functionalities.

Thanks!

rnikutta commented 7 months ago

Hi @nesquivelr Thank you for the PR! We'll review it in the coming few days and will be back with any comments and/or change requests.

nesquivelr commented 6 months ago

Hi @rnikutta, thank you for reviewing this pull request. I added all your suggestion to the code. Here are my comments:

Regarding the TOC, starting from 0 is the desired numbering since the other ANTARES Jupyter notebooks start with the same number.
I added the GCN link in some parts of the notebook, I don't know if this is what you meant, let me know if I misunderstood please.
I'll be looking forward to the disclaimer update to finishing updating this notebook.

nesquivelr commented 5 months ago

@jacquesalice thanks for reviewing these changes. I updated the Jupyter notebook including all your suggestions

rnikutta commented 5 months ago

Hi @nesquivelr apologies for the long delay. We decided to merge your NB and we will update the Acknowledgments section ourselves at a later time. Thank you for contributing this NB!