astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
57 stars 48 forks source link

Remove redundant SDSS visualization notebook #226

Closed weaverba137 closed 3 months ago

weaverba137 commented 3 months ago

This PR:

weaverba137 commented 3 months ago

I've now copied the useful information from the old notebook into the new notebook. Please review the additional text just before the DESI prospect display. Displays for SDSS & BOSS are unchanged.

weaverba137 commented 3 months ago

Also, this PR needs to be re-tested after I have installed the latest version of prospect for the DESI 23.1 kernel.

rnikutta commented 3 months ago

Hi @weaverba137 is this still in draft state, or ready for review? If ready, can you please assign a reviewer?

weaverba137 commented 3 months ago

Yes, @jacquesalice, please review.

weaverba137 commented 3 months ago

HTML files are now updated.

weaverba137 commented 3 months ago

However, this PR needs to be re-tested after I have installed the latest version of prospect for the DESI 23.1 kernel.

weaverba137 commented 3 months ago

Nevermind.

jacquesalice commented 3 months ago

Oooop, I'll re-test it anyway

jacquesalice commented 3 months ago

Tested on gp13 and prospect on the DESI 23.1 kernel still works!

rnikutta commented 3 months ago

I think @weaverba137 meant he has yet to install said update on that kernel.

weaverba137 commented 3 months ago

Prospect 1.3.3 is now installed in the DESI 23.1, and I ran the notebooks with that. No problems.