search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 48 forks source link

Gp13updates #227

Closed rnikutta closed 6 months ago

rnikutta commented 6 months ago

Fixing 2 data reduction NBs for gp13, by re-running them with the updated kernels.

rnikutta commented 6 months ago

@jacquesalice and @bmerino95 can you please review these NBs. Just execute on gp13 to confirm that they work. Don't change the kernel, this is precisely the test: "do they run with the newly assigned kernels"? Thanks.

bmerino95 commented 6 months ago

Hi @rnikutta. I loaded both notebooks into GP13 and was able to run DataReductionPyrafGMOS.ipynb without a problem because it automatically changed the kernel to Gemini (Py3.8). However, DataReductionDragonsGMOS.ipynb stayed in the Python 3 kernel and crashed while trying to run the first cell because it could not find the DRAGONS libraries.

rnikutta commented 6 months ago

Thanks for trying it out @bmerino95 . Just to make sure: did you switch the branch, after cloning the repo on gp13?

bmerino95 commented 6 months ago

@rnikutta Thank you for pointing that out! I was on the wrong branch. This time DataReductionDragonsGMOS.ipynb successfully opened the DRAGONS (Py3.7) kernel and ran without any issues. I also retested DataReductionPyrafGMOS.ipynb and it also worked without any issues.

rnikutta commented 6 months ago

Great, many thanks @bmerino95 Can you please submit your review with "Approve" option selected, so that I can merge (w/o having tom override ;-))

rnikutta commented 6 months ago

Thanks for your reviews @bmerino95 and @jacquesalice. Merged.