search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 48 forks source link

Updated markup in DRAGONS notebooks #232

Closed bmerino95 closed 5 months ago

bmerino95 commented 6 months ago

I have incorporated David's suggestions into the notebooks and updated version for each notebook. All notebooks run on GP13.

rnikutta commented 6 months ago

@bmerino95 thanks. Can you request @kareninysimba to review these latest changes?

bmerino95 commented 6 months ago

@rnikutta Good idea! I just added him as a reviewer.

rnikutta commented 5 months ago

@kareninysimba any chance your could greenlight this PR today? (I'd like to merge it first before merging @bmerino95's Acks&Disclaimer PR. Thanks!

kareninysimba commented 5 months ago

@rnikutta I made suggestions about the original scope of my initial suggestions. For the sake of hurry, @bmerino95 can skip them. Only real typo is in comment #2 (for GMOS_Imaging_Galaxy.ipynb) where I think it should say fringe instead of flat.

bmerino95 commented 5 months ago

Hi @kareninysimba. Thank you for your feedback. I have made the changes you recommended and made the statement for the standard star in the NIRI notebook more generic as well.

bmerino95 commented 5 months ago

Thank you for catching that. I just changed the text under 'Create master bias' in GMOS_Longslit_WhiteDwarf.ipynb.

bmerino95 commented 5 months ago

Saw the old text there and removed it. Now, just the updated text is there.