astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 48 forks source link

NB Disclaimer and Acks update - IO Batch #233

Closed i-olin closed 5 months ago

i-olin commented 6 months ago

@bmerino95 please review these updates, feedback is appreciated.

Updated Disclaimers and Attributions Sections along with version strings.

Notes:

./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/2_GOGREENDr1SIA.ipynb ./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/3_GOGREENDr1ClusterMembership.ipynb ./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/4_GOGREENDr1Spec1DRedshift.ipynb

bmerino95 commented 6 months ago

Hi Isabella! Everything looks good here. Nice work!

rnikutta commented 6 months ago

Hi @i-olin one small change request: in the GOGREEN notebooks, the anchor names for the TOC links and at the section titles are sometimes not the same. E.g, in NB 2_GOGREEN...:

# Table of contents
* [Disclaimer & attribution](#disclaimer)

but the Section anchor is actually:

<a class="anchor" id="attribution"></a>
# Disclaimer & attribution

For NB 3_GOGREEN.. the TOC has

* [Disclaimer & attribution](#GGdisclaimer)

but the Section has


<a class="anchor" id="attribution"></a>

Could you please check all NBs in your batch, and fix the mismatch? Thanks!
i-olin commented 5 months ago

Hi @rnikutta

I fixed those mismatched anchor names in the GOGREEN NBs and made sure the other NBs did not have the same issue.

Thank you!

rnikutta commented 5 months ago

Hi @i-olin many thanks, looks good! Merging the PR.