Closed i-olin closed 5 months ago
Hi Isabella! Everything looks good here. Nice work!
Hi @i-olin one small change request: in the GOGREEN notebooks, the anchor names for the TOC links and at the section titles are sometimes not the same. E.g, in NB 2_GOGREEN...:
# Table of contents
* [Disclaimer & attribution](#disclaimer)
but the Section anchor is actually:
<a class="anchor" id="attribution"></a>
# Disclaimer & attribution
For NB 3_GOGREEN.. the TOC has
* [Disclaimer & attribution](#GGdisclaimer)
but the Section has
<a class="anchor" id="attribution"></a>
Could you please check all NBs in your batch, and fix the mismatch? Thanks!
Hi @rnikutta
I fixed those mismatched anchor names in the GOGREEN NBs and made sure the other NBs did not have the same issue.
Thank you!
Hi @i-olin many thanks, looks good! Merging the PR.
@bmerino95 please review these updates, feedback is appreciated.
Updated Disclaimers and Attributions Sections along with version strings.
Notes:
./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/2_GOGREENDr1SIA.ipynb ./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/3_GOGREENDr1ClusterMembership.ipynb ./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/4_GOGREENDr1Spec1DRedshift.ipynb
./03_ScienceExamples/GOGREEN_GalaxiesInRichEnvironments/1_GOGREENDr1DataAccessAtDataLab.ipynb did not have a Disclaimers and Attributions section. A new cell was added with the updated template.
The Large Scale Structure NB is only executed to before the "Large scale structure in 3D" section. Output data volume past this point is very large.