search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
60 stars 48 forks source link

NB Disclaimer and Acks update - BM batch #234

Closed bmerino95 closed 5 months ago

bmerino95 commented 6 months ago

Updated the Disclaimer and Acks for 11 notebooks.

rnikutta commented 5 months ago

@bmerino95 one NB in your batch has a conflict, likely because I just merged your DRAGONS NBs, and one of them was this very NB. I'll attempt to resolve it by pushing to your branch.

And I'll review the entire batch (today and/or tomorrow).

rnikutta commented 5 months ago

@bmerino95 I think I resolved the merge conflict correctly. I'm still checking the offending NB 04_HowTos/DataReduction/DRAGONS_reduction_examples/GMOS_Imaging_StarryField/GMOS_Imaging_StarryField.ipynb --> It seems to have both your Disclaimer & Acks changes, and the updated language from David's comments.

If you could also please take a quick look and let me know whether things look alright? Thanks!

bmerino95 commented 5 months ago

Hey @rnikutta. I just looked through the GMOS_Imaging_StarryField.ipynb and it looks good. The disclaimer/acknowledgments are updated and David’s suggestions are present.

rnikutta commented 5 months ago

Thanks @bmerino95 I will attempt a merge! Fingers crossed..