search

astro-datalab / notebooks-latest

Default set of Data Lab notebooks, by DL team and contributed by users
BSD 3-Clause "New" or "Revised" License
57 stars 48 forks source link

Add __nbid__ to all NBs. Template has '0000'. No IDs for EPO notebook… #243

Closed rnikutta closed 1 month ago

rnikutta commented 1 month ago

…s (they aren't controlled by us). No updates to NB version strings.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

rnikutta commented 1 month ago

@kareninysimba @jacquesalice @bmerino95 could you please review this PR? It adds __nbid__ = '0034' etc to every NB (first cell with the NB metadata). The template NB file has nbid '0000', the rest are incremental numbers, but formatted as a 4-digit long zero-padded string.

I also had to update one NB (1_GOGREEN...) because the metadata cell had the variables without the double-underscores.

Finally, I on purpose didn't update the __version__ strings (except int he template ipynb file).

Thanks!

rnikutta commented 1 month ago

Thanks @jacquesalice . Good catch! Turns out I had another non-tracked ipynb file in my clone when I generated the list of files to number... and that one got 0031. I'll run the thing again today.

rnikutta commented 1 month ago

@jacquesalice @bmerino95 @kareninysimba how about now?

rnikutta commented 1 month ago

Thanks all. Made one more commit to add a csv file (nbid.csv) that maps the nbid values to the specific NB files (as discussed in the DEV meeting today). Will merge now.