search

astrojs / fitsjs

JavaScript library for reading the FITS astronomical format. Functionality includes reading of images, data cubes, compressed images, binary and ascii tables.
http://astrojs.github.io/fitsjs/
MIT License
85 stars 21 forks source link

Include version in js file #17

Closed Merg1255 closed 10 years ago

Merg1255 commented 10 years ago

@kapadia Streamline the dev process. Include in every generated js file the corresponding version, along with the distribution licence information.

And of course, the original creator of the library. :)

kapadia commented 10 years ago

@Merg1255 The version number appears in the lib (though not at the top of the file). https://github.com/astrojs/fitsjs/blob/master/lib/fits.js#L230

but accessible via 

astro.FITS.version

I prefer not to attach the license, mostly to save on file size, but also following practice done by other libs such as d3.

Merg1255 commented 10 years ago

@kapadia I think the a better example is the way the Bootstrap project has organized its js files. https://github.com/twbs/bootstrap/blob/master/js/button.js

So instead of having a comment line on top declaring that the js file is generated from a compiler, you could have a few more characters declaring biefly the version, the licence and the creator. It just makes it look more consistent. :)