search

astrojs / fitsjs

JavaScript library for reading the FITS astronomical format. Functionality includes reading of images, data cubes, compressed images, binary and ascii tables.
http://astrojs.github.io/fitsjs/
MIT License
85 stars 21 forks source link

Dev code cleanup #20

Open Merg1255 opened 10 years ago

Merg1255 commented 10 years ago

@kapadia As mentioned in the README, the code file should be free from repeated code that spawns web workers.

kapadia commented 10 years ago

We have some repeated code when reading compressed images, which is why I haven't enabled reading them asynchronously. There is also some repeated code when swapping endian, but it's minimal. Have I missed something?

Avoiding this redundancy would mean another rewrite. Do you have any suggestions?

Merg1255 commented 10 years ago

@kapadia I started this topic just to have in a plan for a rewrite. Since I'm using the JS version, the rewrite should be based completely on your preferences.