search

astropy / astropy-benchmarks

Benchmarks for the astropy project
https://spacetelescope.github.io/bench/astropy-benchmarks/
BSD 3-Clause "New" or "Revised" License
7 stars 27 forks source link

Fix typo #56

Closed larrybradley closed 6 years ago

nden commented 6 years ago

Thanks!

nden commented 6 years ago

Apparently it expects someone else to do a review.

larrybradley commented 6 years ago

Thanks, @nden! Apparently you don't have write access (neither do I) -- "At least 1 approving review is required by reviewers with write access."

larrybradley commented 6 years ago

CC: @pllim ?

pllim commented 6 years ago

I want to consult @astrofrog on how this name change is going to affect the cron stuff that he set up. Last time names were changed, some manual JSON tweaking was necessary, if I remember correctly.

astrofrog commented 6 years ago

Yes this requires also fixing all the files in the results branch. Could one of you open a PR to do that? (just search and replace the change)

astrofrog commented 6 years ago

Actually I'll just do this directly without a PR - I think a PR will crash if we try and edit 30000 files.

astrofrog commented 6 years ago

Fixed the results files in https://github.com/astropy/astropy-benchmarks/commit/288ba7375fc290ad271dc96b749d5e032533eb0b