search

astropy / astropy-v2.0-paper

Repository for the second Astropy paper
https://github.com/astropy/astropy-v2.0-paper/blob/master-pdf/main.pdf
16 stars 33 forks source link

Warning for LS periodograms #141

Closed hamogu closed 6 years ago

hamogu commented 6 years ago

From the referee's report:

Note from statistical editor. In sec 3.11.3, a sentence can be added warning users about difficulties in interpreting the statistical significance of Lomb-Scargle periodogram peaks. This is important because unreliable interpretation is common, and warnings are not given elsewhere (e.g. NASA Exoplanet Archive Periodogram Service). A good reference is Vanderplas 2017 (https://arxiv.org/abs/1703.09824) soon to appear in the ApJ Suppl.

I don't think this is a controversial suggestion, I just wanted to make an issue for it so we don't forget because it is listed with the other "major points".

crawfordsm commented 6 years ago

cc: @jakevdp -- just in case you aren't familiar with this citation

jakevdp commented 6 years ago

I could definitely be persuaded to cite Vanderplas 2017 here :smile:

crawfordsm commented 6 years ago

@jakevdp can you add some text by 28 Feb? You can either include your response to the referee in the comment to the PR or directly in the file response.txt

adrn commented 6 years ago

I think this was fixed in #149!