search

astropy / astropy-v2.0-paper

Repository for the second Astropy paper
https://github.com/astropy/astropy-v2.0-paper/blob/master-pdf/main.pdf
16 stars 33 forks source link

Add new panel to figure with N contributors per month #152

Closed adrn closed 6 years ago

adrn commented 6 years ago

This addresses #150. The figure now looks like this:

commits

adrn commented 6 years ago

I actually think we could remove the middle panel and replace with the new right panel. What do others think?

crawfordsm commented 6 years ago

I'm okay with both -- commits and committers are different and I think they both provide some relevant information to the reader.

It probably isn't easy to make, but I would be curious to see a second line of first time committers per month added to the last panel.

bsipocz commented 6 years ago

It probably isn't easy to make, but I would be curious to see a second line of first time committers per month added to the last panel.

I suspect that line will be super noisy, around 4-5 in Feb-March, and much smaller during the summer.

Also another measure could be along with the number of commits is either the number of PRs, or the cumulative lines of code (the latter I think the best of all three, number of commits varies much more than the number of lines for individual committers).

bsipocz commented 6 years ago

@hamogu - I disagree here, the referee specifically asked for providing more info about why we say this is still a healthy project. While I haven't looked into the link they suggested, my naive ideas about the health of a software project involves having a stable contributor group, and the new figure shows that to me. We still have a ~20 contributors/per month, so it's not the toy project of a very few individuals.

hamogu commented 6 years ago

Ok, that convinces me. Let's merge this!On Feb 22, 2018 7:43 AM, Brigitta Sipocz notifications@github.com wrote:@hamogu - I disagree here, the referee specifically asked for providing more info about why we say this is still a healthy project. While I haven't looked into the link they suggested, my naive ideas about the health of a software project involves having a stable contributor group, and the new figure shows that to me. We still have a ~20 contributors/per month, so it's not the toy project of a very few individuals.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

adrn commented 6 years ago

@hamogu I think you agree now, but in case you need more convincing, I think the referee did explicitly ask for this panel! (see #150)