asyncapi / java-spring-cloud-stream-template

Java Spring Cloud Stream template for the AsyncAPI Generator
31 stars 33 forks source link

@JsonProperty will not get imported in java file #304

Open pasinski opened 1 year ago

pasinski commented 1 year ago

Describe the bug

If the property name is different from the type name it references @JsonProperty annotation gets added for the field. However, no import com.fasterxml.jackson.annotation.JsonProperty

How to Reproduce

Create schema file example-jsonproperty.yaml with following content:

asyncapi: 2.5.0
info:
  title: JsonProperty Example
  version: 1.0.2
  description: | 
    This file contains schema definition, where some of the elements require ' @JsonProperty`. The annotation will get added to properties by `@asyncapi/java-spring-cloud-stream-template` however the import statement will not get added to the class file
defaultContentType: application/json
channels:
  helloWorld:
    description: |
      Greet User.
    publish:
      message:
        oneOf:
          - $ref: '#/components/messages/helloWorld'

components:

  messages:
    helloWorld:
      title: Hello World
      summary: 'Event: Greet the world'
      payload:
        $ref: '#/components/schemas/GreetingMessage'

  schemas:
    GreetingMessage:
        type: object
        required:
          - "greetingText"
          - "newsOfTheDay"
        properties:
          greetingText:
            type: string
            const: "Hello World"
          newsOfTheDay:
            $ref: '#/components/schemas/NewsOfTheDayType'
    NewsOfTheDayType:
      type: object
      required:
        - "theNews"
      properties:
        theNews:
          type: string

Generate app with command ag example-jsonproperty.yaml @asyncapi/java-spring-cloud-stream-template -p artifactId=anschluss-events -p groupId=de.db.sab.kira -p javaPackage=de.db.sab.ki ra.anschlussEvents -o example-jsonproperty --force-write

Expected behavior

import com.fasterxml.jackson.annotation.JsonProperty; should get added to the imports section of generated java file

pcermak commented 1 year ago

Hi there, is somebody working on the issue? I have the same problem. @pasinski did you solve the bug somehow?

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity :sleeping:

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience :heart:

dwij2812 commented 1 year ago

+1, Facing the same problem.