atk4 / login

Add-on implementing User Login, Registration, Management and Password
https://agiletoolkit.org
MIT License
26 stars 22 forks source link

Fix session_start() Notice #18

Closed acicovic closed 5 years ago

acicovic commented 5 years ago

In the latest development version of ATK UI and during exceptions, Auth->init() gets called twice. This fixes the notice by checking if session_start() is already active.

acicovic commented 5 years ago

Well, it's not really a fix. It's just a workaround to avoid the message for the time being. The real issue probably lies within ATK UI and it could be related to https://github.com/atk4/ui/issues/786.

So I don't mind if this pull request doesn't make it because it doesn't give a solution but rather a quick fix to stop the annoyance.

acicovic commented 5 years ago

OK, I understand what happened. I am using 1.0.1 which doesn't have this check. So I did this quickly without realizing. Closing this.