atk4 / login

Add-on implementing User Login, Registration, Management and Password
https://agiletoolkit.org
MIT License
26 stars 22 forks source link

reuse App on displayForm #42

Closed abbadon1334 closed 4 years ago

abbadon1334 commented 4 years ago

The old way to display an exception or a login form was to stop the current App and create a new one. I manage to reuse the App, fix phpunit, remove deprecated code and do some cleanup.

codecov[bot] commented 4 years ago

Codecov Report

Merging #42 into develop will decrease coverage by 0.12%. The diff coverage is 1.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #42      +/-   ##
============================================
- Coverage       6.30%   6.17%   -0.13%     
  Complexity       186     186              
============================================
  Files             18      18              
  Lines            476     486      +10     
============================================
  Hits              30      30              
- Misses           446     456      +10     
Impacted Files Coverage Δ Complexity Δ
src/ACL.php 0.00% <ø> (ø) 14.00 <0.00> (ø)
src/Auth.php 0.00% <0.00%> (ø) 28.00 <2.00> (ø)
src/Feature/PasswordManagement.php 0.00% <0.00%> (ø) 67.00 <38.00> (ø)
src/Feature/SendEmailAction.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
src/Feature/SetupModel.php 0.00% <0.00%> (ø) 16.00 <7.00> (ø)
src/Feature/Signup.php 0.00% <ø> (ø) 2.00 <0.00> (ø)
src/Feature/UniqueFieldValue.php 0.00% <0.00%> (ø) 3.00 <3.00> (ø)
src/FormField/AbstractDropDown.php 0.00% <0.00%> (ø) 4.00 <4.00> (ø)
src/FormField/ActionsDropDown.php 0.00% <0.00%> (ø) 4.00 <4.00> (ø)
src/FormField/FieldsDropDown.php 0.00% <0.00%> (ø) 3.00 <3.00> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 764e49d...f1b045b. Read the comment docs.