mkrecek234 commented 4 years ago

Adjusting atk4/login to all introduced BC breaks in 2.1 Please note in Auth.php there is one unclear part that had to be commented out to make atk4/login work. Issue with ACL not being properly enforced remains

mkrecek234 commented 4 years ago

Resolves issue #43

codecov[bot] commented 4 years ago

Codecov Report

Merging #44 into develop will decrease coverage by 3.29%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             develop     #44      +/-   ##
============================================
- Coverage       6.17%   2.88%   -3.30%     
  Complexity       186     186              
============================================
  Files             18      18              
  Lines            486     486              
============================================
- Hits              30      14      -16     
- Misses           456     472      +16

Impacted Files	Coverage Δ	Complexity Δ
src/Auth.php	`0.00% <0.00%> (ø)`	`28.00 <1.00> (ø)`
src/FormField/AbstractDropDown.php	`0.00% <0.00%> (ø)`	`4.00 <0.00> (ø)`
src/LoginForm.php	`0.00% <0.00%> (ø)`	`7.00 <0.00> (ø)`
src/RoleAdmin.php	`0.00% <0.00%> (ø)`	`3.00 <0.00> (ø)`
src/UserAdmin.php	`0.00% <0.00%> (ø)`	`5.00 <0.00> (ø)`
src/Field/Password.php	`28.00% <0.00%> (-32.00%)`	`18.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71f962a...970d953. Read the comment docs.

atk4 / login

Refactoring to ATK 2.1 #44

Codecov Report