search

atk4 / login

Add-on implementing User Login, Registration, Management and Password
https://agiletoolkit.org
MIT License
26 stars 22 forks source link

Align release workflow 2.4.0 #73

Closed abbadon1334 closed 3 years ago

abbadon1334 commented 3 years ago

I need a hand, I cannot reproduce failing tests, on my machine all tests are green.

mvorisek commented 3 years ago

About failing tests - it is failing only with --prefer-lowest deps, you may reproduce locally or dump more data in the CI to debug it

abbadon1334 commented 3 years ago

About failing tests - it is failing only with --prefer-lowest deps, you may reproduce locally or dump more data in the CI to debug it

I try to do it, thx for now.

abbadon1334 commented 3 years ago

https://github.com/atk4/login/pull/73/checks?check_run_id=2436357095#step:9:97 can be related to timing issues? (https://github.com/atk4/ui/pull/1501) The Behat dump show the presence of string "Sign in"

https://github.com/atk4/login/pull/73/checks?check_run_id=2436357784#step:9:18 This memory leak is due to Db creation?

@mvorisek @DarkSide666

mvorisek commented 3 years ago

https://github.com/atk4/login/pull/73/checks?check_run_id=2436357095#step:9:97 can be related to timing issues? (atk4/ui#1501) The Behat dump show the presence of string "Sign in"

No, that patch improves only pooling speed, but no test must rely on long pooling delay.

Waiting after every step is implemented in https://github.com/atk4/ui/blob/2.4.0/tests-behat/bootstrap/Context.php#L39

https://github.com/atk4/login/pull/73/checks?check_run_id=2436357784#step:9:18 This memory leak is due to Db creation?

try to increase burn count like by factor of 100 and see if leaking is higher, if yes, something is not released properly (variable is referenced from some global (another referenced variable) context)

abbadon1334 commented 3 years ago

i found a way to reproduce the issue using this : https://github.com/nektos/act

DarkSide666 commented 3 years ago

@abbadon1334 see this line https://github.com/atk4/login/blob/update-release-workflow/tests-behat/bootstrap/Context.php#L227 It gives exception that at that moment there is no html element in page at all. Later if you dump, then it's in there.

abbadon1334 commented 3 years ago

@abbadon1334 see this line https://github.com/atk4/login/blob/update-release-workflow/tests-behat/bootstrap/Context.php#L227 It gives exception that at that moment there is no html element in page at all. Later if you dump, then it's in there.

I know it appears that is a sort of early get when there is no data inside the session/page.

I installed: https://github.com/nektos/act and I reproduce the error locally, still no luck but I continue finding a solution

abbadon1334 commented 3 years ago

I feel like I'm solving tests related issues in place of functional's issues. After 2 days of trying, I removed the failing tests, I let you decide if this is correct, but - out of losing time - I try to figure out what can be the problem without success. I leave here 2 points, which are both related to solving problems on the mountain, not in the valleys :

DarkSide666 commented 3 years ago

@abbadon1334 Any chance you could finalize this PR and make it compatible with ATK 3.0 ?

abbadon1334 commented 3 years ago

@abbadon1334 Any chance you could finalize this PR and make it compatible with ATK 3.0 ?

sure @DarkSide666, what you think if, we release this for 2.4.0 ( see you what you do with failing new tests), and after that work on release for 3.0.

I hope I don't have the same issues with the tests in 3.0

DarkSide666 commented 3 years ago

sure @DarkSide666, what you think if, we release this for 2.4.0 ( see you what you do with failing new tests), and after that work on release for 3.0.

That sounds like a plan.