atk4 / login

Add-on implementing User Login, Registration, Management and Password
https://agiletoolkit.org
MIT License
26 stars 22 forks source link

Password field in 3.0 not working #75

Closed abbadon1334 closed 3 years ago

abbadon1334 commented 3 years ago

Field password store the hash in property $passwordHash

in 2.4 - after load is still present in the field : image

in 3.0 - after load is not present in the field : image

I think it comes from here: https://github.com/atk4/data/blob/54cd831430139a2b6f8db72630272398abe301d8/src/Model.php#L1248

We copy only the data, the fields are reset losing any internal variables.

Conceptually is perfect, this is hot code and we must avoid any complex operations, but I think someone with a deeper knowledge of the recent @atk4/data development must take a look (@DarkSide666 @mvorisek @georgehristov) and decide to rewrite Password Field or Model load flow.