search

atlarge-research / opencraft

Other
5 stars 2 forks source link

Add comments to pom and remove unused dependencies - [merged] #123

Closed jdonkervliet closed 4 years ago

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 6, 2020, 22:20

Merges feature/clean-up-maven-config -> development

This merge request solves issue #19. It adds:

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 6, 2020, 23:02

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 09:31

changed title from {-a-}dd comments to pom and remove unused dependencies to {+A+}dd comments to pom and remove unused dependencies

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 09:31

changed the description

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 10:23

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 10:26

marked as a Work In Progress

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 12:09

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 12:21

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 12:22

unmarked as a Work In Progress

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 12:22

changed the description

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:50

Commented on etc/checkstyle.xml line 109

Are there replacements for these config lines? (this one and the next)

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:52

Commented on pom.xml line 48

Not an interpreter. More like a implementation/definition/declaration, right?

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:52

Commented on etc/checkstyle.xml line 109

Nope, the issue leads to the removal of this feature said that it should not be up to checkstyle to decide this. https://github.com/checkstyle/checkstyle/issues/7329

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:53

Commented on pom.xml line 71

What does that mean?

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:53

Commented on pom.xml line 48

Yeah you're right Ill change that

        <!-- bukkit api implementation-->
jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:53

Commented on pom.xml line 24

Why is JUnit jupiter's version placed here, while the JUnit4 one is at its dependency?

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:54

Commented on pom.xml line 71

Fastutil adds extra utility classes that are like the utility classes in java.util, but are not found in java.util

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:54

Commented on pom.xml line 159

Why the additional info? Just Mocking utility is enough I think.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:54

Commented on pom.xml line 24

Cause there are multiple imports of being made from org.junit.jupiter which all require the same version, while there is only one junit 4 import

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:55

Commented on pom.xml line 159

Oke

        <!-- Mocking utility -->
jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:55

Commented on pom.xml line 159

changed this line in version 6 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:55

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:55

Commented on pom.xml line 48

changed this line in version 7 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:55

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:55

Commented on pom.xml line 196

This Yardstick comment should be removed.

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:56

Commented on pom.xml line 234

Do we need this?

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:56

Commented on pom.xml line 314

Is this the latest version? I thought there was an M4?

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 13:58

Commented on pom.xml line 446

This was configured in two different places. Are both required? And if so, shouldn't we move the settings to the properties (to prevent someone forgetting to alter one of the two when required)?

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 13:59

Commented on pom.xml line 234

Nope

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:00

Commented on pom.xml line 314

                <version>3.0.0-M4</version>
jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:00

Commented on pom.xml line 314

yeah you're right

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:00

Commented on pom.xml line 314

changed this line in version 8 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:00

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 14:04

Commented on pom.xml line 71

Okay, maybe write it as: Extend Java util package? The native packages aren't libraries, and extension seems to fit better.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:04

Commented on pom.xml line 446

I'll look into it

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 14:05

Commented on pom.xml line 24

You're right! Didn't notice that before.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:05

Commented on pom.xml line 234

changed this line in version 9 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:05

added 2 commits

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 14:05

Commented on etc/checkstyle.xml line 109

Okay, that seems a bit odd. But there nothing we can do about it.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:11

Commented on pom.xml line 446

changed this line in version 10 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:11

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:12

Commented on pom.xml line 446

done

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:13

Commented on pom.xml line 71

changed this line in version 11 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:13

Commented on pom.xml line 196

changed this line in version 11 of the diff

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:13

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:14

Commented on pom.xml line 234

removed

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 14:14

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @swabbur on May 7, 2020, 14:14

resolved all threads

jdonkervliet commented 4 years ago

In GitLab by @larsdetombe on May 7, 2020, 17:55

Please try to merge the development branch in this branch, because it is behind right now.

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 17:59

added 1 commit

Compare with previous version

jdonkervliet commented 4 years ago

In GitLab by @julian9499 on May 7, 2020, 18:00

resolved all threads