search

atlassian-labs / storybook-addon-performance

🚧 A storybook addon to help better understand and debug performance for React components.
https://storybook-addon-performance.netlify.com
Other
652 stars 32 forks source link

:zap: chore: Fixed yarn warning #107

Closed bryanjtc closed 1 year ago

bryanjtc commented 2 years ago

Fixes #106 I added react-is to dependencies to fix a yarn warning of missing peer-dependency from styled-components.

atlassian-cla-bot[bot] commented 2 years ago

Hooray! All contributors have signed the CLA.

bryanjtc commented 1 year ago

@DarkPurple141 Can you check this pr?

bryanjtc commented 1 year ago

@DarkPurple141 I need a review on this change.

DarkPurple141 commented 1 year ago

Is this resolvable downstream?

bryanjtc commented 1 year ago

Is this resolvable downstream?

Yes, but yarn pnp requires all peer dependencies to be added to the package.json

bryanjtc commented 1 year ago

Superseeded by #112