atlassian-labs / storybook-addon-performance

🚧 A storybook addon to help better understand and debug performance for React components.
https://storybook-addon-performance.netlify.com
Other
654 stars 33 forks source link

feat: Add storybook 7 compability #113

Closed bryanjtc closed 1 year ago

bryanjtc commented 2 years ago

Fixes: #112

TODO: Add complete react 18 support. Depends on #117

DarkPurple141 commented 1 year ago

Just running the builds let's see what happens. Although at this stage there are no active tests verifying the esm config change.

bryanjtc commented 1 year ago

Not sure why the jobs fail on netlify. Storybook v7 is now on beta. I can try to expand the pr and add some tests for projects that use esm.

jgodi commented 1 year ago

@bryanjtc Excitingly waiting this PR -- is there anything that I can do to help?

I just discovered this addon and would love to use it. If there are beta versions of this published, I am happy to test it out.

bryanjtc commented 1 year ago

@DarkPurple141 Can you update the image in heroku? It's the only check failing.

bryanjtc commented 1 year ago

I will do a follow-up pr when storybook starts releasing rc for v7.

jgodi commented 1 year ago

Could you cut a release with this change please?

On Sat, Feb 4, 2023 at 2:57 PM Bryan Thomas @.***> wrote:

I will do a follow-up pr when storybook starts releasing rc for v7.

— Reply to this email directly, view it on GitHub https://github.com/atlassian-labs/storybook-addon-performance/pull/113#issuecomment-1416848347, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUTD2BHHAKCAQ6JJTSAFLWV27DXANCNFSM6AAAAAARMCD5GM . You are receiving this because you commented.Message ID: @.*** com>