search

atlassian-labs / storybook-addon-performance

🚧 A storybook addon to help better understand and debug performance for React components.
https://storybook-addon-performance.netlify.com
Other
652 stars 32 forks source link

Issue with version 0.17.1 and Storybook 6 and react.js 18 #137

Open silversonicaxel opened 1 year ago

silversonicaxel commented 1 year ago

This issue is the evolution of the issue https://github.com/atlassian-labs/storybook-addon-performance/issues/132

With these libs :

    "react": "^18.2.0",
    "react-dom": "^18.2.0",

    "@storybook/addon-a11y": "^6.5.16",
    "@storybook/addon-actions": "^6.5.16",
    "@storybook/addon-essentials": "^6.5.16",
    "@storybook/addon-interactions": "^6.5.16",
    "@storybook/addon-links": "^6.5.16",
    "@storybook/addons": "^6.5.16",
    "@storybook/builder-webpack5": "^6.5.16",
    "@storybook/manager-webpack5": "^6.5.16",
    "@storybook/mdx2-csf": "^0.0.3",
    "@storybook/react": "^6.5.16",
    "@storybook/theming": "^6.5.16",
    "storybook-addon-performance": "^0.17.1",

and this config in main.ts :

   addons: [
     { name: '@storybook/addon-a11y' },
     { name: '@storybook/addon-essentials',   
     { 
       name: '@storybook/addon-essentials',
       options: { backgrounds: false },
     },
     { name: '@storybook/addon-interactions' },
     { name: '@storybook/addon-links' },
     { name: 'storybook-addon-performance' },
   ],

and this config in preview.tsx :

import { withPerformance } from 'storybook-addon-performance';

...

export const decorators = [
  (Story: FC): JSX.Element => {
    return (
      <ThemeProvider>
        <Story />
      </ThemeProvider>
    );
  },
  withPerformance
];

making the Storybook server up and running has no errors occurring, but the Performance addon is not appearing on the addons section.

other ideas?

is it related to this https://github.com/atlassian-labs/storybook-addon-performance/issues/108 and https://github.com/atlassian-labs/storybook-addon-performance/pull/117 ?