search

atlassian-labs / storybook-addon-performance

🚧 A storybook addon to help better understand and debug performance for React components.
https://storybook-addon-performance.netlify.com
Other
652 stars 32 forks source link

Hydrate is run when only client tasks are allowed #57

Closed robinmetral closed 3 years ago

robinmetral commented 3 years ago

We're using the allowedGroups filter to run the addon only on the client, because SSR tasks are failing on production builds.

Screenshot 2020-11-13 at 11 30 25

The PR for this feature (#40) intended to disable Hydrate (which depends on SSR) for client only configs, however, Hydrate is always ran:

Screenshot 2020-11-13 at 15 06 30

(☝️ the Hydrate task should not be run here)

Reproduce this on the example Storybook