search

atlassian-labs / storybook-addon-performance

🚧 A storybook addon to help better understand and debug performance for React components.
https://storybook-addon-performance.netlify.com
Other
652 stars 32 forks source link

Usage recommendation: dev server vs static build #94

Closed sheelah closed 2 years ago

sheelah commented 2 years ago

Thanks for creating this awesome add-on! 🙌🏻

Question on recommended usage: is this designed to be run only off a static Storybook build, so that the production version of React is used? The React docs recommend doing perf benchmarking when using the minified prod build (not the dev server) so I'm wondering if that applies here too. Thanks for any insight.

DarkPurple141 commented 2 years ago

Yes it's recommended to use a production build, although it does work with a dev build. You'll see less variability with production.

sheelah commented 2 years ago

Thank you @DarkPurple141! If the team would like, I'm happy to submit a PR adding a note about this to the documentation.

DarkPurple141 commented 2 years ago

That would be great, please submit one and I'll triage it through.

sheelah commented 2 years ago

PR for this: https://github.com/atlassian-labs/storybook-addon-performance/pull/98