search

atom-minimap / minimap

A preview of the full source code.
https://atom.io/packages/minimap
MIT License
645 stars 130 forks source link

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null #489

Closed jpcofr closed 8 years ago

jpcofr commented 8 years ago

[Enter steps to reproduce below:]

  1. Opened a makefile in a panel and a .ts file in a different panel
  2. Closed the .ts file without deleting the panel

Atom Version: 1.7.4 System: Mac OS X 10.11.5 Thrown From: minimap package, v4.24.2

Stack Trace

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null

At /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:336

TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
    at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:336:28)
    at StableAdapter.computeScrollTop (/Users/jpcf/.atom/packages/minimap/lib/adapters/stable-adapter.js:54:42)
    at StableAdapter.getScrollTop (/Users/jpcf/.atom/packages/minimap/lib/adapters/stable-adapter.js:47:17)
    at Minimap.getTextEditorScrollRatio (/Users/jpcf/.atom/packages/minimap/lib/minimap.js:519:25)
    at Minimap.getCapedTextEditorScrollRatio (/Users/jpcf/.atom/packages/minimap/lib/minimap.js:531:29)
    at Minimap.getScrollTopFromEditor (/Users/jpcf/.atom/packages/minimap/lib/minimap.js:852:12)
    at Minimap.getScrollTop (/Users/jpcf/.atom/packages/minimap/lib/minimap.js:806:14)
    at Minimap.getLastVisibleScreenRow (/Users/jpcf/.atom/packages/minimap/lib/minimap.js:784:13)
    at Minimap.emitRangeChanges (/Users/jpcf/.atom/packages/minimap/lib/mixins/decoration-management.js:497:38)
    at Minimap.emitDecorationChanges (/Users/jpcf/.atom/packages/minimap/lib/mixins/decoration-management.js:482:10)
    at Minimap.removeAllDecorationsForMarker (/Users/jpcf/.atom/packages/minimap/lib/mixins/decoration-management.js:575:12)
    at /Users/jpcf/.atom/packages/minimap/lib/mixins/decoration-management.js:349:14
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at TextEditorMarker.module.exports.TextEditorMarker.destroyed (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:229:20)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:37:24
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at Marker.module.exports.Marker.destroy (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker.js:252:27)
    at TextEditorMarker.module.exports.TextEditorMarker.destroy (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-marker.js:43:25)
    at MinimapHighlightSelectedView.module.exports.HighlightedAreaView.removeMarkers (/Users/jpcf/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:152:12)
    at MinimapHighlightSelectedView.removeMarkers (/Users/jpcf/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at MinimapHighlightSelectedView.handleSelection (/Users/jpcf/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:38:8)
    at MinimapHighlightSelectedView.handleSelection (/Users/jpcf/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at MinimapHighlightSelectedView.subscribeToActiveTextEditor (/Users/jpcf/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:96:8)
    at /Users/jpcf/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:15:8
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:346:27
    at Pane.module.exports.Pane.observeActiveItem (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:223:7)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:344:42
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at PaneContainer.module.exports.PaneContainer.setActivePane (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:196:22)
    at Pane.module.exports.Pane.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:807:15)
    at PaneContainer.module.exports.PaneContainer.activateNextPane (/Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:250:26)

Commands

     -1:46 editor:newline (atom-text-editor.editor.is-focused)
     -1:42.6.0 core:move-up (atom-text-editor.editor.is-focused)
     -1:42.1.0 editor:newline (atom-text-editor.editor.is-focused)
     -1:40.3.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:34.7.0 core:copy (atom-text-editor.editor.is-focused)
     -1:33.4.0 core:paste (atom-text-editor.editor.is-focused)
     -1:31.6.0 core:move-left (atom-text-editor.editor.is-focused)
 26x -1:31.3.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
  6x -1:28.5.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -1:26.3.0 editor:select-to-beginning-of-word (atom-text-editor.editor.is-focused)
     -1:21.5.0 core:move-right (atom-text-editor.editor.is-focused)
 19x -1:21.1.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -1:17.3.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:11.2.0 core:save (atom-text-editor.editor.is-focused)
     -1:09.9.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -1:09.2.0 editor:newline (atom-text-editor.editor.is-focused)

Config

{
  "minimap": {
    "plugins": {
      "highlight-selected": true,
      "highlight-selectedDecorationsZIndex": 0
    }
  }
}

Installed Packages

# User
atom-beautify, v0.29.7
atom-typescript, v8.10.2
auto-detect-indentation, v1.0.0
highlight-line, v0.11.1
highlight-selected, v0.11.2
json-colorer, v0.3.0
language-latex, v0.6.1
last-cursor-position, v0.9.0
latexer, v0.3.0
linter, v1.11.4
minimap, v4.24.2
minimap-highlight-selected, v4.4.0
pretty-json, v1.4.0
terminal-plus, v0.14.5

# Dev
No dev packages
postoroniy commented 8 years ago

same on linux

  1. right click button and then "split to right"
  2. on different window on left right tabs and split to right again
  3. when minimap appeared scroll up and down
  4. close one window
  5. close last window 6.enjoy;)

Atom Version: 1.8.0 System: Linux Mint Thrown From: minimap package, v4.24.6

Stack Trace

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null

At /usr/local/share/atom/resources/app.asar/src/text-editor-element.js:336

TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
    at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/usr/local/share/atom/resources/app.asar/src/text-editor-element.js:336:28)
    at StableAdapter.computeScrollTop (/home/slava/.atom/packages/minimap/lib/adapters/stable-adapter.js:54:42)
    at StableAdapter.getScrollTop (/home/slava/.atom/packages/minimap/lib/adapters/stable-adapter.js:47:17)
    at Minimap.getTextEditorScrollRatio (/home/slava/.atom/packages/minimap/lib/minimap.js:521:25)
    at Minimap.getCapedTextEditorScrollRatio (/home/slava/.atom/packages/minimap/lib/minimap.js:533:29)
    at Minimap.getScrollTopFromEditor (/home/slava/.atom/packages/minimap/lib/minimap.js:854:12)
    at Minimap.getScrollTop (/home/slava/.atom/packages/minimap/lib/minimap.js:808:14)
    at Minimap.getLastVisibleScreenRow (/home/slava/.atom/packages/minimap/lib/minimap.js:786:13)
    at Minimap.emitRangeChanges (/home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:497:38)
    at Minimap.emitDecorationChanges (/home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:482:10)
    at Minimap.removeAllDecorationsForMarker (/home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:575:12)
    at /home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:349:14
    at Function.module.exports.Emitter.simpleDispatch (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at TextEditorMarker.module.exports.TextEditorMarker.destroyed (/usr/local/share/atom/resources/app.asar/src/text-editor-marker.js:229:20)
    at /usr/local/share/atom/resources/app.asar/src/text-editor-marker.js:37:24
    at Function.module.exports.Emitter.simpleDispatch (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at Marker.module.exports.Marker.destroy (/usr/local/share/atom/resources/app.asar/node_modules/text-buffer/lib/marker.js:252:27)
    at TextEditorMarker.module.exports.TextEditorMarker.destroy (/usr/local/share/atom/resources/app.asar/src/text-editor-marker.js:43:25)
    at MinimapHighlightSelectedView.module.exports.HighlightedAreaView.removeMarkers (/home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:152:12)
    at MinimapHighlightSelectedView.removeMarkers (/home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at MinimapHighlightSelectedView.handleSelection (/home/slava/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:38:8)
    at MinimapHighlightSelectedView.handleSelection (/home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at MinimapHighlightSelectedView.subscribeToActiveTextEditor (/home/slava/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:96:8)
    at /home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:15:8
    at Function.module.exports.Emitter.simpleDispatch (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/local/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at /usr/local/share/atom/resources/app.asar/src/pane-container.js:346:27
    at Pane.module.exports.Pane.observeActiveItem (/usr/local/share/atom/resources/app.asar/src/pane.js:223:7)

Commands

  2x -1:57.7.0 tree-view:reveal-active-file (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "disabledPackages": [
      "script",
      "ink",
      "julia-client",
      "language-gfm",
      "git-control"
    ]
  },
  "minimap": {
    "absoluteMode": true,
    "plugins": {
      "highlight-selected": true,
      "highlight-selectedDecorationsZIndex": 0
    }
  }
}

Installed Packages

# User
autocomplete-julia, v0.1.0
git-diff-details, v1.3.0
hex, v0.6.2
highlight-selected, v0.11.2
language-dot, v1.6.0
language-julia, v0.6.0
language-markdown, v0.14.0
language-rust, v0.4.6
language-swift, v0.4.0
language-tcl, v0.1.2
language-verilog, v0.4.0
language-vhdl, v0.7.2
merge-conflicts, v1.4.4
minimap, v4.24.6
minimap-highlight-selected, v4.4.0
open-recent, v5.0.0

# Dev
No dev packages
scippio commented 8 years ago

same here ... When I want move panel to new position.

ashtonmeuser commented 8 years ago
  1. Atom presents 'editor window in not responding' error.
  2. Click 'Keep waiting'.

Atom Version: 1.7.3 System: Ubuntu 16.04.1 Thrown From: minimap package, v4.24.7

Stack Trace

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null

At /usr/share/atom/resources/app.asar/src/text-editor-element.js:336

TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
    at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/usr/share/atom/resources/app.asar/src/text-editor-element.js:336:28)
    at StableAdapter.computeScrollTop (/home/ameuser/.atom/packages/minimap/lib/adapters/stable-adapter.js:54:42)
    at StableAdapter.getScrollTop (/home/ameuser/.atom/packages/minimap/lib/adapters/stable-adapter.js:47:17)
    at Minimap.getTextEditorScrollRatio (/home/ameuser/.atom/packages/minimap/lib/minimap.js:521:25)
    at Minimap.getCapedTextEditorScrollRatio (/home/ameuser/.atom/packages/minimap/lib/minimap.js:533:29)
    at Minimap.getScrollTopFromEditor (/home/ameuser/.atom/packages/minimap/lib/minimap.js:854:12)
    at Minimap.getScrollTop (/home/ameuser/.atom/packages/minimap/lib/minimap.js:808:14)
    at Minimap.getLastVisibleScreenRow (/home/ameuser/.atom/packages/minimap/lib/minimap.js:786:13)
    at Minimap.emitRangeChanges (/home/ameuser/.atom/packages/minimap/lib/mixins/decoration-management.js:497:38)
    at Minimap.emitDecorationChanges (/home/ameuser/.atom/packages/minimap/lib/mixins/decoration-management.js:482:10)
    at Minimap.decorateMarker (/home/ameuser/.atom/packages/minimap/lib/mixins/decoration-management.js:418:10)
    at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.markRange (/home/ameuser/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:66:14)
    at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.addDecorations (/home/ameuser/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:55:10)
    at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.updateDiffs (/home/ameuser/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:44:8)
    at Immediate._onImmediate (/home/ameuser/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:1:1)
    at processImmediate [as _immediateCallback] (timers.js:383:17)

Commands

     -4:03.2.0 project-plus:toggle-project-finder (atom-text-editor.editor.is-focused)
     -3:52 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "activate-power-mode",
      "project-manager",
      "wrap-guide",
      "pigments"
    ],
    "packagesWithKeymapsDisabled": [
      "atom-beautify",
      "highlight-selected",
      "increment-me",
      "color-picker",
      "linter"
    ]
  },
  "minimap": {
    "plugins": {
      "git-diff": true,
      "git-diffDecorationsZIndex": 0,
      "highlight-selected": true,
      "highlight-selectedDecorationsZIndex": 0
    }
  }
}

Installed Packages

# User
atom-beautify, v0.29.10
change-case, v0.6.3
column-select, v0.2.0
file-icons, v1.7.17
highlight-selected, v0.11.2
language-javascript-jsx, v0.3.7
linter, v1.11.14
minimap, v4.24.7
minimap-git-diff, v4.3.1
minimap-highlight-selected, v4.4.0
project-plus, v0.9.0

# Dev
No dev packages
zba commented 8 years ago

Got this after install project-plus, always happen when switching projects.

andrewkdouglas commented 8 years ago

I have "Remove empty panes" on and get this error when closing the last tab in an open pane.

Also, note that for me this seems to happen at the same time as: https://github.com/atom/atom/issues/11186

Refreshing window fixes the issue

abe33 commented 8 years ago

Hi there, sorry for the delay, is anyone is able to reproduce that on stable or beta? I'm running 1.11.0-dev-89c638a and I don't seems to get that error with the various scenario proposed.

ashtonmeuser commented 8 years ago
  1. Switch projects using project-plus package

Atom Version: 1.7.3 System: Ubuntu 16.04.1

Installed Packages

# User
activate-power-mode@0.7.4
atom-beautify@0.29.10
column-select@0.2.0
file-icons@1.7.18
highlight-selected@0.11.2
increment-me@0.3.0
language-javascript-jsx@0.3.7
linter@1.11.16
minimap@4.24.7
minimap-git-diff@4.3.1
minimap-highlight-selected@4.4.0
pigments@0.31.2
project-plus@0.9.0
dricogit commented 8 years ago

I have same problem with project-viewer. It appear when switching project, but only if the file in the current tab of the loaded project, had some git modification.

Last Atom version and last packages version

mwmessin commented 8 years ago

my temporary "fix"

atom-notification.fatal {
  opacity: 0;
  pointer-events: none;
}

😈

scippio commented 8 years ago

I have atom-editor version 1.10.x and I think it's ok now... pls test it ;)

Strae commented 8 years ago

Atom 1.10.12 here, same problem. Open atom, switch project; Saving the first file visualized will cause the error. Close and reopen the file, everything works as expected

postoroniy commented 8 years ago

[Enter steps to reproduce below:]

  1. split right
  2. split right again
  3. close most right panel Please refer to Commands section

Atom Version: 1.11.1 Electron Version: 0.37.8 System: Linux Mint Thrown From: minimap package, v4.25.0

Stack Trace

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null

At /home/travis/build/atom/atom/out/app/src/text-editor-element.coffee:288

TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
    at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/usr/share/atom/resources/app.asar/src/text-editor-element.js:288:28)
    at StableAdapter.computeScrollTop (/home/slava/.atom/packages/minimap/lib/adapters/stable-adapter.js:54:42)
    at StableAdapter.getScrollTop (/home/slava/.atom/packages/minimap/lib/adapters/stable-adapter.js:47:17)
    at Minimap.getTextEditorScrollRatio (/home/slava/.atom/packages/minimap/lib/minimap.js:530:25)
    at Minimap.getCapedTextEditorScrollRatio (/home/slava/.atom/packages/minimap/lib/minimap.js:542:29)
    at Minimap.getScrollTopFromEditor (/home/slava/.atom/packages/minimap/lib/minimap.js:863:12)
    at Minimap.getScrollTop (/home/slava/.atom/packages/minimap/lib/minimap.js:817:14)
    at Minimap.getLastVisibleScreenRow (/home/slava/.atom/packages/minimap/lib/minimap.js:795:13)
    at Minimap.emitRangeChanges (/home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:501:38)
    at Minimap.emitDecorationChanges (/home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:486:10)
    at Minimap.removeAllDecorationsForMarker (/home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:579:12)
    at /home/slava/.atom/packages/minimap/lib/mixins/decoration-management.js:350:14
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at DisplayMarker.module.exports.DisplayMarker.destroy (/usr/share/atom/resources/app.asar/node_modules/text-buffer/lib/display-marker.js:29:20)
    at MinimapHighlightSelectedView.module.exports.HighlightedAreaView.removeMarkers (/home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:152:12)
    at MinimapHighlightSelectedView.removeMarkers (/home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at MinimapHighlightSelectedView.handleSelection (/home/slava/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:38:8)
    at MinimapHighlightSelectedView.handleSelection (/home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:1:1)
    at MinimapHighlightSelectedView.subscribeToActiveTextEditor (/home/slava/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected-view.coffee:96:8)
    at /home/slava/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:15:8
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at /usr/share/atom/resources/app.asar/src/pane-container.js:346:27
    at Pane.module.exports.Pane.observeActiveItem (/usr/share/atom/resources/app.asar/src/pane.js:229:7)
    at /usr/share/atom/resources/app.asar/src/pane-container.js:344:42
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at PaneContainer.module.exports.PaneContainer.setActivePane (/usr/share/atom/resources/app.asar/src/pane-container.js:196:22)
    at Pane.module.exports.Pane.activate (/usr/share/atom/resources/app.asar/src/pane.js:835:15)

Commands

  4x -0:47.7.0 core:move-down (atom-text-editor.editor.is-focused)
  3x -0:46.5.0 editor:move-line-up (atom-text-editor.editor.is-focused)
     -0:45.5.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
 18x -0:45.2.0 core:delete (atom-text-editor.editor.is-focused)
     -0:42.3.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
  3x -0:41.2.0 core:move-down (atom-text-editor.editor.is-focused)
  2x -0:40.2.0 editor:move-line-up (atom-text-editor.editor.is-focused)
  2x -0:38.6.0 core:backspace (atom-text-editor.editor.is-focused)
 18x -0:37.3.0 core:delete (atom-text-editor.editor.is-focused)
     -0:33.1.0 core:save (atom-text-editor.editor.is-focused)
     -0:32.6.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -0:32.3.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
     -0:31.2.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:30.7.0 core:select-down (atom-text-editor.editor.is-focused)
     -0:30.5.0 core:delete (atom-text-editor.editor.is-focused)
     -0:29.9.0 core:save (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "customFileTypes": {
      "source.ini": [
        ".buckconfig",
        ".flowconfig"
      ],
      "source.json": [
        ".arcconfig",
        "BUCK.autodeps"
      ],
      "source.python": [
        "BUCK"
      ]
    },
    "disabledPackages": [
      "language-gfm",
      "git-control",
      "nuclide"
    ],
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_Store",
      "._*",
      "Thumbs.db",
      ".pioenvs",
      ".piolibdeps",
      ".clang_complete",
      ".gcc-flags.json"
    ],
    "telemetryConsent": "limited"
  },
  "minimap": {
    "adjustAbsoluteModeHeight": true,
    "plugins": {
      "highlight-selected": true,
      "highlight-selectedDecorationsZIndex": 0
    }
  }
}

Installed Packages

# User
autocomplete-swift, v1.0.2 (active)
git-diff-details, v1.3.0 (active)
git-history, v3.2.0 (inactive)
git-plus, v5.18.0 (active)
git-time-machine, v1.5.3 (inactive)
graphviz-preview, v1.7.0 (inactive)
hex, v0.6.2 (active)
highlight-selected, v0.11.2 (active)
Hydrogen, v0.14.0 (inactive)
language-dot, v1.6.0 (active)
language-julia, v0.8.0 (active)
language-markdown, v0.16.3 (active)
language-matlab, v0.2.1 (active)
language-rust, v0.4.7 (active)
language-scala, v1.1.6 (active)
language-swift, v0.4.0 (active)
language-tcl, v0.1.2 (active)
language-verilog, v0.4.0 (active)
language-vhdl, v0.7.2 (active)
merge-conflicts, v1.4.4 (active)
minimap, v4.25.0 (active)
minimap-highlight-selected, v4.4.0 (active)
nuclide, v0.175.0 (inactive)
open-recent, v5.0.0 (active)
swift-debugger, v0.1.2 (inactive)
tool-bar, v1.0.1 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.44.0 (inactive)
base16-tomorrow-dark-theme, v1.2.0 (inactive)
base16-tomorrow-light-theme, v1.2.0 (inactive)
one-dark-ui, v1.6.0 (active)
one-light-ui, v1.6.0 (inactive)
one-dark-syntax, v1.3.0 (active)
one-light-syntax, v1.3.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.7.0 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.2 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.201.1 (active)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.59.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.0 (active)
metrics, v1.0.0 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.242.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.68.2 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.101.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.209.3 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.33.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.2 (active)
language-csharp, v0.12.1 (active)
language-css, v0.37.1 (active)
language-gfm, v0.88.0 (inactive)
language-git, v0.15.0 (active)
language-go, v0.42.1 (active)
language-html, v0.45.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.23.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.2 (active)
language-less, v0.29.5 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.2 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.69.0 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.56.0 (active)
language-shellscript, v0.22.4 (active)
language-source, v0.9.0 (active)
language-sql, v0.23.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.9 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages
Ben3eeE commented 8 years ago
  1. Ensure you have minimap and minimap-highlight-selected installed and enabled.
  2. Open Atom. I opened Atom master repo.
  3. Open any file. I opened package.json in the Atom master repo.
  4. Select a word by double clicking on it. I double clicked on hackable.
  5. Run the pane:split-right-and-copy-active-item command.
  6. Close the right pane that just opened.

Expected: Pane to close. Actual: Minimap throws error, pane stays open and interacting with it throws the Pane has been destroyed error. Atom Version: 1.12.0-beta2. OS: Windows 10 anniversary. Reproduces how often: 100%

minimap error

yajo commented 8 years ago

After last comments, still more information needed?

abe33 commented 8 years ago

I've published a new version that should guard against missing editors in many operations. Unfortunately I couldn't reproduce the issue on my device (which run OSX), so I guess there is some kind of delay between the destruction of the editor and the dispatch of the destroyed event.

Let me know if it helped.

@Ben3eeE totally off topic, but what's your syntax theme? It looks damn pretty!

Ben3eeE commented 8 years ago

@abe33 atom-material-syntax

I will try to reproduce this later with the new version and report back. I did a quick test now on minimap@4.25.5 and was still able to reproduce but I have messed up my packages by installing incompatible versions among other things so can't say for sure that my results are reliable.

yajo commented 8 years ago

I just updated to minimap 4.25.6 and when switching project like in https://github.com/atom-minimap/minimap/issues/489#issuecomment-242203207 I still get:

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
/home/travis/build/atom/atom/out/app/src/text-editor-element.coffee:288
Hide Stack Trace
TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
    at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/usr/share/atom/resources/app.asar/src/text-editor-element.js:288:28)
    at StableAdapter.computeScrollTop (/home/yajo/.atom/packages/minimap/lib/adapters/stable-adapter.js:60:42)
    at StableAdapter.getScrollTop (/home/yajo/.atom/packages/minimap/lib/adapters/stable-adapter.js:51:17)
    at Minimap.getTextEditorScrollRatio (/home/yajo/.atom/packages/minimap/lib/minimap.js:530:25)
    at Minimap.getCapedTextEditorScrollRatio (/home/yajo/.atom/packages/minimap/lib/minimap.js:542:29)
    at Minimap.getScrollTopFromEditor (/home/yajo/.atom/packages/minimap/lib/minimap.js:865:12)
    at Minimap.getScrollTop (/home/yajo/.atom/packages/minimap/lib/minimap.js:819:14)
    at Minimap.getLastVisibleScreenRow (/home/yajo/.atom/packages/minimap/lib/minimap.js:797:13)
    at Minimap.emitRangeChanges (/home/yajo/.atom/packages/minimap/lib/mixins/decoration-management.js:501:38)
    at Minimap.emitDecorationChanges (/home/yajo/.atom/packages/minimap/lib/mixins/decoration-management.js:486:10)
    at Minimap.decorateMarker (/home/yajo/.atom/packages/minimap/lib/mixins/decoration-management.js:419:10)
    at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.markRange (/home/yajo/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:66:14)
    at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.addDecorations (/home/yajo/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:55:10)
    at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.updateDiffs (/home/yajo/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:44:8)
    at Immediate._onImmediate (/home/yajo/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:1:1)
    at tryOnImmediate (timers.js:534:15)
    at processImmediate [as _immediateCallback] (timers.js:514:5)
Ben3eeE commented 8 years ago

Yeah this seems to still be an issue. I can also reproduce with project-plus if I have some text selected before switching projects.

Don't have access to a mac to verify that this issue only occurs on Linux and Windows.

abe33 commented 8 years ago

But how is it possible to get to the pixelPositionForScreenPosition call when every access to the text editor and its view are now protected? Like this https://github.com/atom-minimap/minimap/blob/master/lib/adapters/stable-adapter.js#L55

The test being performed like this: 

editorDestroyed () {
    return !this.textEditor ||
           this.textEditor.isDestroyed() ||
           !this.textEditorElement.getModel()
}

It looks like some really troublesome concurrency issue that can't be solved completely on my end. Who sanely consider protecting every statement with a condition, and event with that, if the reference is destroyed between the condition and the block executed next the issue will still occur.

ummahusla commented 7 years ago

Still have this issue, even tho my Atom is up to date.

C:\...\atom\app-1.12.6\resources\app.asar\src\text-editor-element.js:282
Ben3eeE commented 7 years ago

Make sure you are using the latest version of the minimap package.

ummahusla commented 7 years ago

@Ben3eeE Yeah, I've updated all packages and it seems to be sorted out now. Thanks 👍

Sly777 commented 7 years ago

I just change js file after update atom packages and that's it :)

Atom Version: 1.12.7 Electron Version: 1.3.13 System: Mac OS X 10.12.1 Thrown From: minimap package, v4.25.7

Stack Trace

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null

At /Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:282

TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
  at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:282:28)
  at StableAdapter.computeScrollTop (/Users/ilkerguller/.atom/packages/minimap/lib/adapters/stable-adapter.js:86:44)
  at StableAdapter.getScrollTop (/Users/ilkerguller/.atom/packages/minimap/lib/adapters/stable-adapter.js:74:19)
  at Minimap.getTextEditorScrollRatio (/Users/ilkerguller/.atom/packages/minimap/lib/minimap.js:617:27)
  at Minimap.getCapedTextEditorScrollRatio (/Users/ilkerguller/.atom/packages/minimap/lib/minimap.js:631:31)
  at Minimap.getScrollTopFromEditor (/Users/ilkerguller/.atom/packages/minimap/lib/minimap.js:1005:28)
  at Minimap.getScrollTop (/Users/ilkerguller/.atom/packages/minimap/lib/minimap.js:952:87)
  at Minimap.getLastVisibleScreenRow (/Users/ilkerguller/.atom/packages/minimap/lib/minimap.js:927:30)
  at Minimap.emitRangeChanges (/Users/ilkerguller/.atom/packages/minimap/lib/mixins/decoration-management.js:585:40)
  at Minimap.emitDecorationChanges (/Users/ilkerguller/.atom/packages/minimap/lib/mixins/decoration-management.js:568:12)
  at Minimap.decorateMarker (/Users/ilkerguller/.atom/packages/minimap/lib/mixins/decoration-management.js:490:12)
  at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.markRange (/Users/ilkerguller/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:66:14)
  at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.addDecorations (/Users/ilkerguller/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:53:10)
  at MinimapGitDiffBinding.module.exports.MinimapGitDiffBinding.updateDiffs (/Users/ilkerguller/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:44:8)
  at /Users/ilkerguller/.atom/packages/minimap-git-diff/lib/minimap-git-diff-binding.coffee:1:1
  at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
  at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/text-buffer.js:1427:25

Commands

     -0:23.6.0 project-manager:list-projects (a.inline-block)
  2x -0:22.5.0 core:move-left (atom-text-editor.editor.mini.is-focused)
 10x -0:22 core:move-down (atom-text-editor.editor.mini.is-focused)
     -0:19.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:05.7.0 core:cut (atom-text-editor.editor.is-focused.hyperclick)
     -0:03.3.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:03.1.0 docblockr:parse-enter (atom-text-editor.editor.is-focused)
     -0:03.1.0 editor:newline (atom-text-editor.editor.is-focused)
     -0:02.9.0 core:paste (atom-text-editor.editor.is-focused.hyperclick)
     -0:01.4.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:00.6.0 core:save (atom-text-editor.editor.is-focused.hyperclick)

Config

{
  "core": {
    "allowPendingPaneItems": false,
    "closeEmptyWindows": false,
    "customFileTypes": {
      "source.ini": [
        ".buckconfig",
        ".flowconfig",
        ".hgrc"
      ],
      "source.json": [
        ".arcconfig",
        "BUCK.autodeps"
      ],
      "source.python": [
        "BUCK"
      ]
    },
    "disabledPackages": [
      "grunt-runner",
      "linter-scss-lint",
      "language-javascript-jsx",
      "linter-flow",
      "tree-view",
      "react",
      "autocomplete-ruby",
      "csscomb",
      "gulp-control",
      "linter-jscs",
      "linter-csslint",
      "imdone-atom",
      "atom-autocomplete-php",
      "angularjs",
      "atom-typescript",
      "dash",
      "language-ocaml",
      "language-thrift",
      "linter-php",
      "language-c",
      "language-clojure",
      "language-coffee-script",
      "language-less",
      "language-perl",
      "language-property-list",
      "language-toml",
      "spell-check"
    ],
    "packagesWithKeymapsDisabled": [
      "terminal-plus"
    ],
    "telemetryConsent": "limited",
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  },
  "minimap": {
    "absoluteMode": true,
    "plugins": {
      "cursorline": true,
      "cursorlineDecorationsZIndex": 0,
      "git-diff": true,
      "git-diffDecorationsZIndex": 0,
      "highlight-selected": true,
      "highlight-selectedDecorationsZIndex": 0,
      "pigments": true,
      "pigmentsDecorationsZIndex": 0
    }
  }
}

Installed Packages

# User
angularjs, v0.3.5 (inactive)
atom-autocomplete-php, v0.20.2 (inactive)
atom-beautify, v0.29.13 (active)
atom-material-syntax, v0.4.6 (active)
atom-material-ui, v1.3.8 (active)
atom-monokai, v0.10.4 (inactive)
atom-ternjs, v0.16.1 (active)
atom-typescript, v10.1.13 (inactive)
autoclose-html, v0.23.0 (active)
autocomplete-css, v0.14.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-modules, v1.6.7 (active)
autocomplete-paths, v1.0.5 (active)
autocomplete-plus, v2.34.2 (active)
autocomplete-ruby, v0.2.3 (inactive)
autocomplete-snippets, v1.11.0 (active)
color-picker, v2.2.3 (active)
compare-files, v0.8.0 (active)
csscomb, v0.3.1 (inactive)
dash, v1.7.0 (inactive)
docblockr, v0.9.1 (active)
dracula-theme, v1.2.8 (inactive)
duotone-dark-syntax, v2.0.1 (inactive)
editorconfig, v2.0.5 (active)
emmet, v2.4.3 (active)
file-icons, v1.7.25 (active)
flatwhite-syntax, v0.8.0 (inactive)
git-blame, v0.4.11 (inactive)
git-control, v0.8.2 (inactive)
git-diff, v1.2.0 (active)
git-history, v3.2.0 (inactive)
git-plus, v5.29.0 (active)
git-time-machine, v1.5.4 (inactive)
grunt-runner, v0.14.0 (inactive)
gulp-control, v0.5.0 (inactive)
highlight-line, v0.11.1 (active)
highlight-selected, v0.11.2 (active)
hyperclick, v0.0.39 (active)
image-view, v0.60.0 (active)
imdone-atom, v2.0.19 (inactive)
language-babel, v2.48.5 (active)
language-batch, v0.3.3 (active)
language-docker, v1.1.7 (active)
language-hyperlink, v0.16.1 (active)
language-ini, v1.17.0 (active)
language-ocaml, v1.1.2 (inactive)
language-sass, v0.57.1 (active)
language-thrift, v1.0.2 (inactive)
linter, v1.11.18 (active)
linter-csslint, v1.3.3 (inactive)
linter-eslint, v8.0.0 (active)
linter-flow, v5.5.0 (inactive)
linter-jscs, v4.1.0 (inactive)
linter-php, v1.3.1 (inactive)
linter-scss-lint, v3.0.4 (inactive)
markdown-preview, v0.159.1 (active)
merge-conflicts, v1.4.4 (active)
minimap, v4.25.7 (active)
minimap-cursorline, v0.2.0 (active)
minimap-git-diff, v4.3.1 (active)
minimap-highlight-selected, v4.4.0 (active)
minimap-pigments, v0.2.2 (active)
monokai, v0.18.0 (inactive)
node-debugger, v1.9.1 (active)
nucleus-dark-ui, v0.10.19 (inactive)
nuclide, v0.191.0 (active)
one-dark-syntax, v1.6.0 (inactive)
php-hyperclick, v1.2.1 (active)
pigments, v0.37.0 (active)
project-manager, v3.3.3 (active)
react, v0.16.1 (inactive)
redux-devtools, v0.5.1 (inactive)
seti-syntax, v1.0.1 (inactive)
seti-ui, v1.4.0 (inactive)
sort-lines, v0.14.0 (inactive)
sync-settings, v0.8.0 (active)
todo-show, v1.8.0 (inactive)
tool-bar, v1.0.1 (active)
tree-view-git-status, v1.3.0 (active)
turbo-javascript, v1.4.0 (inactive)
wakatime, v6.0.10 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (inactive)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.6.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.14.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.34.2 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (active)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.2.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.159.1 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (inactive)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (active)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (inactive)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (inactive)
language-clojure, v0.22.1 (inactive)
language-coffee-script, v0.48.0 (inactive)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (inactive)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (inactive)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (inactive)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.1 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (inactive)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages
yajo commented 7 years ago

I still keep hitting this. Atom 1.12.7 says all my packages are up to date.

$ apm list
Built-in Atom Packages (89)
├── atom-dark-syntax@0.27.0
├── atom-dark-ui@0.52.0
├── atom-light-syntax@0.28.0
├── atom-light-ui@0.45.0
├── base16-tomorrow-dark-theme@1.3.0
├── base16-tomorrow-light-theme@1.3.0
├── one-dark-ui@1.6.2
├── one-light-ui@1.6.2
├── one-dark-syntax@1.5.0
├── one-light-syntax@1.5.0
├── solarized-dark-syntax@1.0.5
├── solarized-light-syntax@1.0.5
├── about@1.7.0
├── archive-view@0.62.0
├── autocomplete-atom-api@0.10.0
├── autocomplete-css@0.13.1
├── autocomplete-html@0.7.2
├── autocomplete-plus@2.31.4
├── autocomplete-snippets@1.11.0
├── autoflow@0.27.0
├── autosave@0.23.1
├── background-tips@0.26.1
├── bookmarks@0.42.0
├── bracket-matcher@0.82.2
├── command-palette@0.39.0
├── deprecation-cop@0.54.1
├── dev-live-reload@0.47.0
├── encoding-selector@0.22.0
├── exception-reporting@0.40.0
├── find-and-replace@0.202.2
├── fuzzy-finder@1.4.0
├── git-diff@1.1.0
├── go-to-line@0.31.0
├── grammar-selector@0.48.2
├── image-view@0.60.0
├── incompatible-packages@0.26.1
├── keybinding-resolver@0.35.0
├── line-ending-selector@0.5.0
├── link@0.31.2
├── markdown-preview@0.158.8
├── metrics@1.1.2
├── notifications@0.65.1
├── open-on-github@1.2.1
├── package-generator@1.0.1
├── settings-view@0.243.1
├── snippets@1.0.4
├── spell-check@0.68.4
├── status-bar@1.4.1
├── styleguide@0.47.2
├── symbols-view@0.113.1
├── tabs@0.103.0
├── timecop@0.33.2
├── tree-view@0.210.0
├── update-package-dependencies@0.10.0
├── welcome@0.35.1
├── whitespace@0.35.0
├── wrap-guide@0.38.2
├── language-c@0.54.0
├── language-clojure@0.22.1
├── language-coffee-script@0.48.0
├── language-csharp@0.13.0
├── language-css@0.40.1
├── language-gfm@0.88.0
├── language-git@0.15.0
├── language-go@0.43.0
├── language-html@0.47.1
├── language-hyperlink@0.16.1
├── language-java@0.24.0
├── language-javascript@0.122.0
├── language-json@0.18.3
├── language-less@0.29.6
├── language-make@0.22.2
├── language-mustache@0.13.0
├── language-objective-c@0.15.1
├── language-perl@0.37.0
├── language-php@0.37.3
├── language-property-list@0.8.0
├── language-python@0.45.1
├── language-ruby@0.70.2
├── language-ruby-on-rails@0.25.1
├── language-sass@0.57.0
├── language-shellscript@0.23.0
├── language-source@0.9.0
├── language-sql@0.25.0
├── language-text@0.7.1
├── language-todo@0.29.1
├── language-toml@0.18.1
├── language-xml@0.34.12
└── language-yaml@0.27.1

Community Packages (32) /home/yajo/.atom/packages
├── activate-power-mode@1.1.0
├── atom-hg@2.0.11
├── atom-material-ui@1.3.8
├── autocomplete-python@1.8.20
├── bug-report@0.7.1
├── editorconfig@2.0.5
├── git-plus@5.29.1
├── language-docker@1.1.7
├── language-fish-shell@1.0.5
├── language-restructuredtext@1.0.1
├── language-rpm-spec@0.11.0
├── linter@1.11.18
├── linter-docker@0.1.4
├── linter-eslint@8.0.0
├── linter-flake8@2.1.4
├── linter-pep8@1.3.2
├── linter-php@1.3.1
├── linter-sass-lint@1.7.4
├── linter-xmllint@1.4.0
├── minimap@4.25.7
├── minimap-bookmarks@0.4.2
├── minimap-find-and-replace@4.5.1
├── minimap-git-diff@4.3.1
├── minimap-highlight-selected@4.4.0
├── minimap-selection@4.4.0
├── odoo-snippets@0.3.0
├── platformio-ide-terminal@2.2.2
├── project-plus@0.9.0
├── quick-highlight@0.6.1
├── rst-preview-pandoc@0.1.12
├── sync-settings@0.8.0
└── tablr@1.8.0

└── (empty)
alankyshum commented 7 years ago

Could we just add a quick hack on the text-editor-element.coffee:209 for null check, and resolve the root cause later? The notifications are kind of annoying, as it causes no trouble on usage~~~

More info: Inside this function pixelPositionForScreenPosition: (screenPosition) -> ...

Just to show how annoying it is: image

astorije commented 7 years ago

Could this issue be re-opened? I'm up-to-date on versions of Atom, minimap and the different bindings for minimap and this is still happening. Thanks!

Ben3eeE commented 7 years ago

Can everyone that still experience this issue with the latest version of minimap please say what you are doing when you see this error? Full steps to reproduce from opening Atom and a list of your installed community packages (The output of apm --list and also atom --version) would be best if you can figure that out. Thanks.

I have notified @abe33 that it should be reopened. This was closed because it was fixed when using the steps posted in https://github.com/atom-minimap/minimap/issues/489#issuecomment-254057876 but it seems that this still happens when using some other steps after reading the comments here.

yajo commented 7 years ago
  1. Install project-plus.
  2. Open Atom within a project.
  3. Switch to another project.
  4. Switch back to 1st project.

My env details here: https://github.com/atom-minimap/minimap/issues/489#issuecomment-268502218

Tokimon commented 7 years ago

I have the same problem and use sort of the same approach as @Yajo, but using project-viewer

Versions apm 1.12.9 npm 3.10.5 node 4.4.5 python git 2.8.0.windows.1 visual studio 2015

Custom packages installed: atom-autocomplete-php@0.20.2 atom-beautify@0.29.14 atom-react-native-autocomplete@0.0.27 atom-typescript@10.1.13 autoclose-html@0.23.0 babel-react-syntax@1.2.0 blame@0.10.2 color-picker@2.2.3 custom-title@1.0.1 docblock-format-helper@0.3.0 docblockr@0.9.1 double-click-tree-view@1.1.0 emmet@2.4.3 emmet-snippets-compatibility@1.0.6 es-identifier-highlight@0.4.3 file-icons@1.7.25 imdone-atom@2.0.20 js-refactor@0.7.4 language-apache@1.7.0 language-babel@2.48.5 language-generic-config@1.3.0 language-javascript-jsx@0.3.7 language-stylus@0.2.0 linter@1.11.18 linter-eslint@8.0.0 linter-htmlhint@1.3.1 linter-js-yaml@1.2.6 linter-json-lint@0.1.1 linter-php@1.3.1 linter-phpcs@1.5.5 minimap@4.25.7 minimap-cursorline@0.2.0 minimap-find-and-replace@4.5.1 minimap-highlight-selected@4.4.0 minimap-linter@1.6.0 minimap-pigments@0.2.2 minimap-selection@4.4.0 navigate@0.1.17 php-cs-fixer@4.1.0 php-hyperclick@1.2.1 php-twig@4.0.0 pigments@0.37.0 project-viewer@0.3.42 refactor@0.11.3 seti-ui@1.4.0 Sublime-Style-Column-Selection@1.7.2 tabs-to-spaces@1.0.2 turbo-javascript@1.4.0

dricogit commented 7 years ago

The error persist on switching tabs with project-plus or project-viewer It happens when a tab is in those cases and switched :

Nothing happens if minimap is clear.

clearmisp commented 7 years ago

This error is still present in the latest release of minimap. I get the error when switching from one project to another using project-manager v 3.3.3.

Atom Version: 1.13.0 Electron Version: 1.3.13 System: "openSUSE Leap Thrown From: minimap package, v4.26.7

Stack Trace

Uncaught TypeError: Cannot read property 'pixelPositionForScreenPosition' of null

At /usr/share/atom/resources/app.asar/src/text-editor-element.js:298

TypeError: Cannot read property 'pixelPositionForScreenPosition' of null
    at atom-text-editor.TextEditorElement.pixelPositionForScreenPosition (/usr/share/atom/resources/app.asar/src/text-editor-element.js:298:28)
    at StableAdapter.computeScrollTop (/home/micke/.atom/packages/minimap/lib/adapters/stable-adapter.js:60:42)
    at StableAdapter.getScrollTop (/home/micke/.atom/packages/minimap/lib/adapters/stable-adapter.js:51:17)
    at Minimap.getTextEditorScrollRatio (/home/micke/.atom/packages/minimap/lib/minimap.js:532:25)
    at Minimap.getCapedTextEditorScrollRatio (/home/micke/.atom/packages/minimap/lib/minimap.js:544:29)
    at Minimap.getScrollTopFromEditor (/home/micke/.atom/packages/minimap/lib/minimap.js:867:12)
    at Minimap.getScrollTop (/home/micke/.atom/packages/minimap/lib/minimap.js:821:14)
    at Minimap.getLastVisibleScreenRow (/home/micke/.atom/packages/minimap/lib/minimap.js:799:13)
    at Minimap.emitRangeChanges (/home/micke/.atom/packages/minimap/lib/mixins/decoration-management.js:503:38)
    at Minimap.emitDecorationChanges (/home/micke/.atom/packages/minimap/lib/mixins/decoration-management.js:488:10)
    at Minimap.decorateMarker (/home/micke/.atom/packages/minimap/lib/mixins/decoration-management.js:418:10)
    at MinimapBookmarksBinding.processDecoration (/home/micke/.atom/packages/minimap-linter/lib/minimap-linter-binding.js:32:52)
    at /home/micke/.atom/packages/minimap-linter/lib/minimap-linter-binding.js:20:78
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at DecorationManager.module.exports.DecorationManager.decorateMarker (/usr/share/atom/resources/app.asar/src/decoration-manager.js:206:20)
    at TextEditor.module.exports.TextEditor.decorateMarker (/usr/share/atom/resources/app.asar/src/text-editor.js:1704:37)
    at /home/micke/.atom/packages/linter/lib/editor-linter.js:59:21
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at EditorLinter.addMessage (/home/micke/.atom/packages/linter/lib/editor-linter.js:143:20)
    at /home/micke/.atom/packages/linter/lib/linter-views.js:111:22
    at Array.forEach (native)
    at LinterViews.notifyEditorLinters (/home/micke/.atom/packages/linter/lib/linter-views.js:109:11)
    at LinterViews.render (/home/micke/.atom/packages/linter/lib/linter-views.js:58:10)
    at /home/micke/.atom/packages/linter/lib/linter.coffee:39:14
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app.asar/node_modules/event-kit/lib/emitter.js:129:28)
    at MessageRegistry.updatePublic (/home/micke/.atom/packages/linter/lib/message-registry.js:84:18)
    at UpdateMessages (/home/micke/.atom/packages/linter/lib/message-registry.js:24:16)

Commands

     -2:16.6.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-always.theme-nord-atom-syntax.theme-nord-atom-ui)
     -1:54.4.0 deprecation-cop:view (atom-workspace.workspace.scrollbars-visible-always.theme-nord-atom-syntax.theme-nord-atom-ui)
     -0:04.4.0 project-manager:list-projects (input.hidden-input)
  3x -0:02.8.0 core:move-down (input.hidden-input)
     -0:01.1.0 core:confirm (input.hidden-input)
     -0:01.0 tree-view:show (atom-workspace.workspace.scrollbars-visible-always.theme-nord-atom-syntax.theme-nord-atom-ui)

Config

{
  "core": {
    "autoHideMenuBar": true,
    "disabledPackages": [
      "atom-commander"
    ],
    "openEmptyEditorOnStart": false,
    "packagesWithKeymapsDisabled": [
      "gdb-debug"
    ],
    "projectHome": "/home/micke/devel/projects",
    "telemetryConsent": "limited",
    "themes": [
      "nord-atom-ui",
      "nord-atom-syntax"
    ]
  },
  "minimap": {
    "plugins": {
      "cursorline": true,
      "cursorlineDecorationsZIndex": 0,
      "find-and-replace": true,
      "find-and-replaceDecorationsZIndex": 0,
      "git-diff": true,
      "git-diffDecorationsZIndex": 0,
      "highlight-selected": true,
      "highlight-selectedDecorationsZIndex": 0,
      "linter": true,
      "linterDecorationsZIndex": 0,
      "split-diff": true,
      "split-diffDecorationsZIndex": 0
    },
    "scrollAnimation": true
  }
}

Installed Packages

# User
atom-beautify, v0.29.16 (inactive)
atom-bracket-highlight, v0.3.1 (active)
atom-clock, v0.1.3 (active)
atom-commander, v0.8.6 (inactive)
atom-dedupe-open-files, v0.1.0 (active)
atom-material-syntax, v1.0.2 (inactive)
atom-material-ui, v1.3.9 (inactive)
autocomplete-bash-builtins, v0.3.4 (active)
autocomplete-clang, v0.10.0 (active)
autocomplete-python, v1.8.26 (active)
autocomplete-xml, v0.9.4 (active)
browser-plus, v0.0.87 (active)
browser-plus-zoom, v0.0.2 (active)
build, v0.67.0 (active)
busy, v0.7.0 (active)
center-line, v1.2.4 (inactive)
chary-tree-view, v0.2.3 (active)
ctags-status, v1.3.7 (active)
docblockr, v0.9.1 (active)
enhanced-tabs, v1.7.0 (inactive)
expose, v0.13.0 (inactive)
file-icons, v2.0.9 (active)
git-blame, v0.4.11 (inactive)
git-log, v0.4.1 (active)
git-plus, v7.1.1 (active)
git-time-machine, v1.5.4 (inactive)
highlight-selected, v0.12.0 (active)
keybinding-cheatsheet, v0.1.1 (inactive)
language-asterisk, v0.1.2 (active)
language-diff, v0.7.0 (active)
language-dotfiles, v1.0.0 (active)
language-groovy, v0.6.0 (active)
language-ini, v1.17.0 (active)
language-log, v1.8.0 (active)
linter, v1.11.21 (active)
linter-cppcheck, v0.2.2 (active)
linter-cpplint, v1.0.1 (active)
linter-gcc, v0.6.15 (active)
linter-perl, v0.8.0 (active)
linter-pylama, v0.8.12 (active)
linter-shellcheck, v1.4.3 (inactive)
linter-xmllint, v1.4.0 (active)
merge-conflicts, v1.4.4 (active)
minimap, v4.26.7 (active)
minimap-find-and-replace, v4.5.1 (active)
minimap-git-diff, v4.3.1 (active)
minimap-highlight-selected, v4.5.0 (active)
minimap-linter, v1.6.0 (active)
minimap-split-diff, v0.3.2 (active)
nord-atom-syntax, v0.5.0 (active)
nord-atom-ui, v0.9.0 (active)
perltidy, v3.0.0 (active)
platformio-ide-terminal, v2.2.2 (active)
project-manager, v3.3.3 (active)
python-indent, v1.0.0 (active)
python-tools, v0.6.9 (active)
raml, v0.2.0 (active)
Remote-FTP, v0.9.4 (active)
restart-atom, v0.2.0 (inactive)
seti-syntax, v1.0.1 (inactive)
seti-ui, v1.4.0 (inactive)
split-diff, v1.1.1 (inactive)
switch-header-source, v0.22.0 (inactive)
tree-view-autoresize, v1.5.0 (active)
tree-view-git-status, v1.3.0 (active)
xml-formatter, v0.10.0 (inactive)
atom-dark-syntax, v0.28.0 (inactive)
atom-dark-ui, v0.53.0 (inactive)
atom-light-syntax, v0.29.0 (inactive)
atom-light-ui, v0.46.0 (inactive)
base16-tomorrow-dark-theme, v1.4.0 (inactive)
base16-tomorrow-light-theme, v1.4.0 (inactive)
one-dark-ui, v1.8.2 (inactive)
one-light-ui, v1.8.2 (inactive)
one-dark-syntax, v1.6.0 (inactive)
one-light-syntax, v1.6.0 (inactive)
solarized-dark-syntax, v1.1.1 (inactive)
solarized-light-syntax, v1.1.1 (inactive)
about, v1.7.2 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.14.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.33.1 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.29.0 (inactive)
autosave, v0.23.2 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.43.2 (active)
bracket-matcher, v0.85.1 (active)
command-palette, v0.39.1 (inactive)
deprecation-cop, v0.55.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.204.5 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.2.0 (active)
go-to-line, v0.31.2 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.1 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.159.1 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.2 (inactive)
settings-view, v0.244.0 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.5 (active)
status-bar, v1.6.0 (active)
styleguide, v0.48.0 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.1 (active)
timecop, v0.33.2 (active)
tree-view, v0.211.1 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.39.0 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.1 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages
yajo commented 7 years ago

I think this line:

@component.pixelPositionForScreenPosition(screenPosition)

Should be changed to:

@component?.pixelPositionForScreenPosition(screenPosition)
PixelT commented 7 years ago

+1 atom version 1.13.1, this bug still exist