search

atsign-foundation / at_java

Java libraries, tools, samples and examples for the atPlatform
BSD 3-Clause "New" or "Revised" License
2 stars 19 forks source link

at_java: atKey.toString() not prefixing `cached:` #160

Open JeremyTubongbanua opened 9 months ago

JeremyTubongbanua commented 9 months ago

The reason why I thought prefixing cached: was incorrect was because of this commen tmade in 2022 : https://github.com/atsign-foundation/at_java/pull/64#issuecomment-1279929240

The Issue:

Java REPL

The first line shows .getAtKeys() working (where it would ultimately use atKey.toString()) The second line shows a raw atProtocol scan where cached: is shown (because that is how the protocol behaves)

@jeremy_0@ /scan shared_key@smoothalligator
  => [@jeremy_0:shared_key@smoothalligator]
@jeremy_0@ scan shared_key@smoothalligator
  => data:["cached:@jeremy_0:shared_key@smoothalligator"]

Correct behaviour should be atKey.toString() should prefix cached: just like the raw scan.

ksanty commented 7 months ago

@JeremyTubongbanua who is working on these and how many SP's?

JeremyTubongbanua commented 7 months ago

@gkc Set this to Active last month...

But there's no immediate need for the Java SDK, I assume, so maybe this is something to backlog? @gkc What do you think? Maybe it could be a good starting intern ticket

I don't think this issue is a pressing issue, which is why I'm bumping it down to P3 as well