search

atsushieno / aap-core

an Audio Plugin Format/Framework for Android
MIT License
92 stars 3 forks source link

MidiDeviceService: UMP is probably incorrectly downconverted to MIDI1 #162

Closed atsushieno closed 8 months ago

atsushieno commented 1 year ago

When I play with aap-resident-midi-keyboard in compose-audio-controls with those aap-juce synths such as OB-Xd or Surge-XT, they seem to receive weird non-linear pitch-bend changes at plugin level. Details need to be analyzed, those DiatonicKeyboard seem to send correct UMPs. Those synths also generate sound as expected when their MidiDeviceServices are in MIDI1 mode.

Probably some bugs in UMP translator.

atsushieno commented 1 year ago

It was actually working fine down to aap-midi-device-service and working fine on aapinstrumentsample (it does not supprot pitchbend so it is only about logged values). aap-juce might have some problem, or it could be at JUCE level.

atsushieno commented 8 months ago

It was fixed by https://github.com/atsushieno/aap-juce/commit/3966ba250a816d090b3e9140177e67072fce30c2.