auanasgheps / snapraid-aio-script

The definitive all-in-one SnapRAID script on Linux. Diff, sync, scrub are things of the past. Manage SnapRAID and much, much more!
GNU General Public License v3.0
225 stars 36 forks source link

Email still sending after removing it #100

Closed helangen closed 1 month ago

helangen commented 3 months ago

Hi,

Thanks for a great script. I noticed that I still receive emails even though I removed or put "" in the email in the config. I can't see that the email is stored somehere else so how do I make it stop? I have set up a webhook via Discord which I prefer.

auanasgheps commented 3 months ago

Hi can you please check your config?

It should be:

EMAIL_ADDRESS=""
FROM_EMAIL_ADDRESS=""
helangen commented 3 months ago

Yeah, I checked it twice. I have tried both

#EMAIL_ADDRESS="" #FROM_EMAIL_ADDRESS=""

and

EMAIL_ADDRESS="" FROM_EMAIL_ADDRESS=""

Still I receive emails which I find weird.

PhilDim1 commented 3 months ago

Same here, actually. Although in my case, it only started doing this once I set the email address and later removed it from the configuration.

helangen commented 2 months ago

So any ideas from the developer why the script still sends emails even though the email is removed in the config?

GerardPolloRebozado commented 2 months ago

I just downloaded the script and set email as "" but I get error while running the script while trying to send email to "" and also say it didn't find the path to the mail bin

auanasgheps commented 2 months ago

Hi all, sorry for the late reply.

I tried replicating the issue, but I did not get any email.

This is the test configuration:

EMAIL_ADDRESS=""
FROM_EMAIL_ADDRESS=""

Here's the output:

Email address is set. Sending email report to **** [Fri May 10 10:49:31 CEST 2024]
sendmail: fatal: (0): No recipient addresses found in message header
Can't send mail: sendmail process failed with error code 75

Yeah, it could be better, because the string "email address is set" is not correct. I'll look into this, but still, I did not receive any email.

I just downloaded the script and set email as "" but I get error while running the script while trying to send email to "" and also say it didn't find the path to the mail bin

This is another issue: it means you're using a distro that does not have mailx. You have two options: you either install mailx or use another mail service via Notification Hooks.

auanasgheps commented 2 months ago

Allright, I fixed the issue, it was quite simple.

The fix is dev branch with the commit d2e5678

Please let me know if it works. In my case the error message disappeared.

PhilDim1 commented 2 months ago

I ended up configuring a whole mail service in the interim, but removing my address in the config produced no errors. Thank you for this software, i'm really happy with it.

helangen commented 2 months ago

Thx. I downloaded the new script now. I will test when it runs at 11:00. My issue was that I set an email initially and then removed it. After that I got this problem. It was not with a fresh run. I’ll give feedback ASAP

helangen commented 2 months ago

Nope, still got an email. Email is set it still says.

auanasgheps commented 2 months ago

@helangen so you're facing another issue. Please check the logs on the server. Does it say it's sending the message to an email address?

helangen commented 2 months ago

@helangen so you're facing another issue. Please check the logs on the server. Does it say it's sending the message to an email address?

I downloaded a fresh script and just set the same parameters as I had previously. Tried running it again.

Which log? /var/log/snapraid.log or the mail log?

helangen commented 2 months ago

Last run did not produce an email. This was after downloading the new script and config file.

auanasgheps commented 2 months ago

That's good news, so it's sorted :)

helangen commented 2 months ago

The dreaded emails just started up again. No changes to the config or script.

auanasgheps commented 2 months ago

Please check /tmp/snapRAID.out and see if at the end of the log you get something like:

## Total time elapsed for SnapRAID: 0hrs 18min 2sec
Email address is set. Sending email report to **MYADDRESS@gmail.com** [Mon 20 May 12:25:03 CEST 2024]
chessgriffin commented 2 months ago

FWIW, I was having the same issues w/ the script trying to send emails even though I had:

EMAIL_ADDRESS=""
FROM_EMAIL_ADDRESS=""

so I tested the version in dev branch with the commit listed above and it works fine. Thanks for the great script.

helangen commented 2 months ago

Please check /tmp/snapRAID.out and see if at the end of the log you get something like:

## Total time elapsed for SnapRAID: 0hrs 18min 2sec
Email address is set. Sending email report to **MYADDRESS@gmail.com** [Mon 20 May 12:25:03 CEST 2024]

This is what I have in the output file:

Total time elapsed for SnapRAID: 2hrs 6min 42sec

Email address is set. Sending email report to **** [ma. 20. mai 12:05:43 +0200 2024]

I will try to re-download and re-configure again. Since other people is having no trouble the error must be on my side.

auanasgheps commented 2 months ago

@helangen yeah, after my last push in dev branch, the issue is on your side because the script is picking up an email address, but you did not configure it.

Please make sure you deleted all previous configurations and try again.

Honestly I don't know what could be causing this, maybe an old config file that the script is picking up.

I'll keep this open for a whule so you can keep us updated. In the meantime I'll release the fix version today :)

helangen commented 2 months ago

Yeah, I have no clue what's causing this. As I said earlier, I configured an email the first time I set it up a few weeks ago but decided to switch to Discord. Then I set the email as blank (""), and after this it was still sending. It shouldn't store the email in other places than the config and I only have one config file in the folder where the script is. Anyways, I downloaded the dev branch (v3.3.2) and re-configured. Made sure there exists only one config file and script file in the folder.

helangen commented 2 months ago

This is my output from todays run.

No sync is in progress.
The 52% of the array is not scrubbed.
You have 35 files with zero sub-second timestamp.
Run the 'touch' command to set it to a not zero value.
No rehash is in progress or needed.
No error detected.

curl: (22) The requested URL returned error: 400
All jobs ended. [ti. 21. mai 13:45:55 +0200 2024]
----------------------------------------
## Total time elapsed for SnapRAID: 3hrs 46min 54sec

I got an email today as well, but I think it has to do with my setup of root aliases in "/etc/aliases" on my server. There I have specified root: . I have the script running via a cron-job as root that probably sends a message to root which again results in the email I hypothesise.

auanasgheps commented 1 month ago

Allright, then I'm going to close this!

helangen commented 1 month ago

Allright, then I'm going to close this!

Yeah. I promise not to re-open 😝