auanasgheps / snapraid-aio-script

The definitive all-in-one SnapRAID script on Linux. Diff, sync, scrub are things of the past. Manage SnapRAID and much, much more!
GNU General Public License v3.0
225 stars 36 forks source link

Fix a few typos and convert all whitespace to be consistent #110

Closed StephenWetzel closed 3 weeks ago

StephenWetzel commented 3 weeks ago

This PR does 3 things:

  1. Fixes a few minor typos
  2. Converts a places where tabs are mixed for indentation to be spaces instead
  3. Trims trailing whitespace

Not trying to start a argument about space vs tabs, but the script already used ~80% spaces, and just had some tabs mixed in a few places, so I just figured it would be better to be consistent.

I have a couple actual PRs I'm still testing, but wanted to get this one up first so I could branch off of it to show just the meaningful changes in those.

auanasgheps commented 3 weeks ago

Thanks for this contribution! Cleanups are always appreciated.

Not trying to start a argument about space vs tabs

I code for fun so don't have any authority in this regard. I prefer tabs because it's just one button to press, but I understand that most of the script has spaces, mostly because in the past other people have helped with this process. A couple of years ago was a real mess with spaces and tab all over the place.

I have a couple actual PRs I'm still testing

Looking forward to your help!

StephenWetzel commented 3 weeks ago

I prefer tabs because it's just one button to press

Just FYI, most editors have a setting to use spaces when you indent with the tab key. And also most should have some setting to automatically convert all indentation to either spaces or tabs when you save a file. That's what mine did here.