search

auanasgheps / snapraid-aio-script

The definitive all-in-one SnapRAID script on Linux. Diff, sync, scrub are things of the past. Manage SnapRAID and much, much more!
GNU General Public License v3.0
231 stars 37 forks source link

Docker Containers - Unpause after sync but before scrub #30

Closed jshank closed 2 years ago

jshank commented 2 years ago

I wanted to minimize the pause duration of my docker containers so I moved the Resume paused containers section of the script before the SCRUB is done. Is there a benefit to having them paused for the SCRUB? Happy to do a PR if that makes sense.

tehniemer commented 2 years ago

Scrub will throw errors if the docker containers make any changes to files that are being scrubbed.

auanasgheps commented 2 years ago

For scrub, SnapRAID manual says the following:

This command verifies the data in your array comparing it with the hash computed in the "sync" command.

So I agree with @tehniemer, since scrub is actually comparing hash with the real data.

Is better to have everything paused/stopped as long as SnapRAID commands are running.

You could consider the "SCRUB_DELAYED_RUN" feature to run scrubs only every once in a while, or reducing scrub percentage/age.

I always welcome contributions, but let's try to stick to SnapRAID best practices!

auanasgheps commented 2 years ago

Closing this issue.