auanasgheps / snapraid-aio-script

The definitive all-in-one SnapRAID script on Linux. Diff, sync, scrub are things of the past. Manage SnapRAID and much, much more!
GNU General Public License v3.0
225 stars 36 forks source link

Unused variable SNAPRAID_CONF #80

Closed tehniemer closed 4 months ago

tehniemer commented 5 months ago

I use OpenMediaVault and am trying out OMV7, in that version the SnapRAID plugin is able to serve muliple arrays so snapraid.conf has a unique name for each array. The variable SNAPRAID_CONF in the config file is able to be set to something different, but it doesn't seem to be referenced at all in the script.

tehniemer commented 5 months ago

I'll look into a fix for this and submit a PR, unless you know how to get it fixed quickly.

auanasgheps commented 5 months ago

Thanks for reporting, I still haven't upgraded to OMV7 but surely that's in the plans.

auanasgheps commented 5 months ago

@tehniemer Is It working fine with OMV7? is there any additional configuration needed?

tehniemer commented 5 months ago

It's working as expected.

It would probably be a good idea to add instructions to the config file about changing the default entry for those using OMV7.

auanasgheps commented 5 months ago

I will add this information to the README on Github later when I'll try OMV7.

Thanks for letting me know.

auanasgheps commented 4 months ago

Working on updating the path to the default OMV7, which will work for users who have one array.

Adding check and notification in case the config file is not found, will also show the file name.

tehniemer commented 4 months ago

I responded to your comment about the name of the .conf file being unpredictable, even with a single array on OMV7 over at that forum. I also think the script should be configured in a way that will allow it to be adaptable to multiple arrays. I'm guessing this could get complicated, but I'm willing to take on the challenge once I get some free time.

Feel free to assign this to me, but maybe a new issue should be opened to address the possibility of multiple arrays.

auanasgheps commented 4 months ago

I can close this issue:

We'll work on improvements in the other issue.