Closed fand closed 8 years ago
Hey! Thanks for all the great pull requests!!! This one is still work in progress I guess. Tests would be nice too.
thx :muscle:
rebased & push -f
ed
https://github.com/WebAudio/web-audio-api/issues/730
PannerNode's setVelocity should be removed
:woot:
Woohoo! :smile:
Now it's ready for review! Updated P-R description.
Hi @fand ! Sorry for the slow response time, I've been super busy last week, and I will be again this week. I should be able to have a look at this the week of the 14th March. Thanks again for all the work you've done :+1: :+1: :+1:
ok, thx!
well done! That's an awesome pull request! Amazing work you did :) I merged it. I think the whole library needs a bit of reorganization (mostly shuffling files around), cause atm it's a bit messy, but that's not your problem ...
:hear_no_evil:
implemented
PannerNode
! Many codes are from chromium's Web Audio API implementation.I'm sorry for +1600 diff... I didn't know PannerNode is such a complicated node.
Files
This P-R includes these files:
Also there are test files for these new modules.
You can try it with
speaker
like this:node test/manual-testing/PannerNode-sound-output.js
Omitted features
I didn't implement HRTFPanner because it's so complicated. There's no test for
setVelocity
because it will be deprecated soon.Some other modules are deprecated in the spec, but I implemented them to make it work.
License issue
I think it doesn't matter that I translated codes from chromium (which are licensed under BSD and GPLv2). If it came a problem I'll find another way... :cow2: