austinnixholm / ThreeFingerDrag

Three Finger Drag feature for Windows precision touchpads.
GNU General Public License v3.0
39 stars 3 forks source link

my workpalce laptop works well, but my home laptop does not. #6

Closed nzin4x closed 7 months ago

nzin4x commented 11 months ago

how can I report current status. is there any debug mode to diagnosis?

https://github.com/ClementGre/ThreeFingersDragOnWindows works well at my home laptop. but this s/w is not little bit smooth.

office laptop : intel cpu home laptop : ryzen 6800u

austinnixholm commented 11 months ago

Thanks for your feedback!

I've made some updates to the software to handle different ways touchpads report data. The new version (v1.2.4) should work better on your home laptop.

Give it a shot and let me know if it solves your problem. You can download the latest version here: ThreeFingerDrag v1.2.4.

nzin4x commented 11 months ago

dear Austinnixholm/Threefingerdrag

Thanks for your support.

Unfortunately, 1.2.4 also doesn't work at my laptop. now I'm using touchpad on asus 13s oled. and I've installed https://github.com/ClementGre/ThreeFingersDragOnWindows before met you and removed it to use your s/w

in contrast, i use apple magic trackpad 2 after installing https://github.com/imbushuo/mac-precision-touchpad/releases, and 1.2.3 works well.

Can I get a diagnosis report to forward information to you?

best regards.

On Fri, Dec 22, 2023 at 10:57 AM Austin Nixholm @.***> wrote:

Thanks for your feedback!

I've made some updates to the software to handle different ways touchpads report data. The new version (v1.2.4) should work better on your office laptop.

Give it a shot and let me know if it solves your problem. You can download the latest version here: ThreeFingerDrag v1.2.4 https://github.com/austinnixholm/ThreeFingerDrag/releases/tag/v1.2.4.

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1867135303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3WIFTLXA2T227EDWELYKTSH5AVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRXGEZTKMZQGM . You are receiving this because you authored the thread.Message ID: @.***>

nzin4x commented 11 months ago

I've run diagnostics branch with visual studio. with debug option I've got some logs. and I've tried to move visual studio window with three finger 2 times. I've turned off three finger option on touchpad setting image

log.zip

austinnixholm commented 11 months ago

Hey, thanks for your patience and for the information from the diagnostic!

Looks like the information is reporting contact ids 0, 1, and 2. With my changes made in 1.2.4, I believe that the contacts are sorting out contact id 0, which is containing valid information that is being ignored, resulting in the events not being fired!

I think the culprit is this code in touch_processor.cpp

ids.erase(std::remove_if(ids.begin(), ids.end(), [](const int id)
        {
            return id > CONTACT_ID_MAXIMUM || id <= 0;
        }), ids.end());

To test this, update and checkout to main branch, and replace that code with the following.

ids.erase(std::remove_if(ids.begin(), ids.end(), [](const int id)
        {
            return id > CONTACT_ID_MAXIMUM;
        }), ids.end());

If you can, please try that out and let me know if it helps!

nzin4x commented 11 months ago

image

I've tried to checkout main branch and pull it again and pasted your code. but sadly not working

austinnixholm commented 11 months ago

Appreciate the update, sorry that wasn't the fix.

After revisiting the data from the log file you provided, I realize I may have initially misunderstood the issue.

Our current system expects to receive the identifiers of all three contacts whenever there's a change in movement involving any finger. However, your device appears to only send the identifiers of the fingers that have moved. This discrepancy could be causing the problem we're encountering.

I'll work on a solution for this, and will get back to you as soon as I can.

nzin4x commented 11 months ago

sorry. I'm not familiar with c++. if you need any help to get diagnostics report. please let me know.

austinnixholm commented 9 months ago

Hey sorry for the long delay in response.

When you get a chance, please give the provided snapshot version a try and let me know if the behavior has improved on your home laptop. Optionally, you can pull down changes from the feature/new-behavior-support and run the program manually instead.

ThreeFingerDrag.1.2.6.1-SNAPSHOT.zip

nzin4x commented 9 months ago

I tried to download but failed. but windows defender it includes virus. "Wacapew.C!ml" so I've turned off realtime detector of windows defender so I could download that file. after that I've turned on realtime detector again. and the file was removed automatically by windows defender. I couldn't run this program. could you please check file?

nzin4x commented 9 months ago

same result.

On Sun, Feb 18, 2024 at 8:58 AM Austin Nixholm @.***> wrote:

Oops! Looks like I'm getting the same false positive from Windows Defender when trying to download the file directly via GitHub, can you try downloading it via the easyupload link here?

https://easyupload.io/e3q25w

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1950584914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3T6LDBTXVNNNTPWR4DYUE72LAVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGU4DIOJRGQ . You are receiving this because you authored the thread.Message ID: @.***>

nzin4x commented 9 months ago

download was blocked again. I can turned off windows defender for feature test purpose. but anyway this file also might not be installed to another github users.

On Sun, Feb 18, 2024 at 9:04 AM Austin Nixholm @.***> wrote:

Try out this installer that I've compiled for you and it should behave like a normal release would:

https://easyupload.io/p4tfab

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1950593717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3VFXUINFMUWHTZHNUDYUFAQLAVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQGU4TGNZRG4 . You are receiving this because you authored the thread.Message ID: @.***>

austinnixholm commented 9 months ago

Sorry for the inconvenience here. Keep Windows Defender settings normal and I'll get this posted on the repository as a pre-release and I'll get back to you.

austinnixholm commented 9 months ago

I've just published the pre-release for the snapshot, feel free to head over there and try again.

https://github.com/austinnixholm/ThreeFingerDrag/releases/tag/v1.2.6.1-SNAPSHOT

nzin4x commented 9 months ago
  1. this snapshot installer couldn't be download

  2. pulled source is also not working

I've checkout out v1.2.6.1-SNAPSHOT tag and run app within visual studio. but 3 firger dragging is not working

  1. here is my diagnostics log.

best regards.

On Sun, Feb 18, 2024 at 11:29 AM Austin Nixholm @.***> wrote:

I've just published the pre-release for the snapshot, feel free to head over there and try again.

https://github.com/austinnixholm/ThreeFingerDrag/releases/tag/v1.2.6.1-SNAPSHOT

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1950811027, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3XYYCEG7M6MKUD36O3YUFRQ3AVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQHAYTCMBSG4 . You are receiving this because you authored the thread.Message ID: @.***>

austinnixholm commented 9 months ago

Hi, thank you for trying that out. I'm not sure why the installer couldn't download, however I also bundled a standalone executable within the pre-release you can try too. I'll try to figure out why there are download issues.

Regarding pulling source code:

The changes that I've made are not on the main branch, so unfortunately the changes you pulled were not from the snapshot.

Please fetch all remotes so you can see the new branch, and checkout to feature/new-behavior-support and try running the code from Visual Studio again. image_2024-02-17_191819283

nzin4x commented 9 months ago

I've switched branch origin/feature/new-behavior-support and not yet working on my laptop. i'm pasting log again.

my windows defender detect virus is in installer. and it blocks to download.

On Sun, Feb 18, 2024 at 12:19 PM Austin Nixholm @.***> wrote:

Hi, thank you for trying that out. I'm not sure why the installer couldn't download, however I also bundled a standalone executable within the pre-release you can try too. I'll try to figure out why there are download issues.

Regarding pulling source code:

The changes that I've made are not on the main branch, so unfortunately the changes you pulled were not from the snapshot.

Please fetch all remotes so you can see the new branch, and checkout to feature/new-behavior-support and try running the code from Visual Studio again. image_2024-02-17_191819283.png (view on web) https://github.com/austinnixholm/ThreeFingerDrag/assets/7199767/ae39a6c8-67c1-48cd-ba24-3e2f5aef6a40

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1950883284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3XBLNYOPL5W6KPQE4DYUFXKZAVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQHA4DGMRYGQ . You are receiving this because you authored the thread.Message ID: @.***>

austinnixholm commented 9 months ago

I'm not seeing the log.txt here, can you try to re-attach it to your post again?

nzin4x commented 9 months ago

OK. But 6 hours later. Thanks.

2024년 2월 18일 (일) 12:28, Austin Nixholm @.***>님이 작성:

I'm not seeing the log.txt here, can you try to re-attach it to your post again?

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1950897506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3XVSOVQK3RTBAWHBVTYUFYPNAVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQHA4TONJQGY . You are receiving this because you authored the thread.Message ID: @.***>

nzin4x commented 9 months ago

this is the log of new-behavior-support branch.

On Sun, Feb 18, 2024 at 1:26 PM nzin4x @.***> wrote:

OK. But 6 hours later. Thanks.

2024년 2월 18일 (일) 12:28, Austin Nixholm @.***>님이 작성:

I'm not seeing the log.txt here, can you try to re-attach it to your post again?

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1950897506, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3XVSOVQK3RTBAWHBVTYUFYPNAVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJQHA4TONJQGY . You are receiving this because you authored the thread.Message ID: @.***>

austinnixholm commented 9 months ago

Sorry but I'm still not seeing it here, that's strange. I'm thinking that the file size of log.txt might be too large for GitHub.

Can you try the following steps?

  1. Open Config folder
  2. Delete log.txt
  3. Start ThreeFingerDrag
  4. Try to perform the gesture once (three fingers down, then move and lift up all fingers)
  5. Close the program
  6. Upload the newly generated log.txt

This should result in a smaller diagnostic file to send.

nzin4x commented 9 months ago

But.. to reduce size. I'm clear log file every time..

https://drive.google.com/file/d/1vhfIG2CFzCneWbGAsmVSWlcRjfydUVLA/view?usp=drivesdk

Here is file link

2024년 2월 19일 (월) 04:21, Austin Nixholm @.***>님이 작성:

Sorry but I'm still not seeing it here, that's strange. I'm thinking that the file size of log.txt might be too large for GitHub.

Can you try the following steps?

  1. Open Config folder
  2. Delete log.txt
  3. Start ThreeFingerDrag
  4. Try to perform the gesture once (three fingers down, then move and lift up all fingers)
  5. Close the program
  6. Upload the newly generated log.txt

This should result in a smaller diagnostic file to send.

— Reply to this email directly, view it on GitHub https://github.com/austinnixholm/ThreeFingerDrag/issues/6#issuecomment-1951420299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACJN3TIYD5YE2KSGQU5LDDYUJICVAVCNFSM6AAAAABA3BZRDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGQZDAMRZHE . You are receiving this because you authored the thread.Message ID: @.***>

nzin4x commented 7 months ago

I've reset my laptop. and now this works well. I'm really happy to use this!