autoatml / autoplex

Code for automated fitting of machine learned interatomic potentials.
https://autoatml.github.io/autoplex/
GNU General Public License v3.0
46 stars 7 forks source link

non-urgent todos regarding the MLIPs in autoplex #77

Open QuantumChemist opened 4 months ago

QuantumChemist commented 4 months ago

just want to note that the following changes should be done to improve the user experience with autoplex

vlderinger commented 1 week ago

Is this a pure enhancement, or are there questions about how we want to separate the datasets? (I'm asking so we can assign the right "label" to this issue)

JaGeo commented 1 week ago

I think @QuantumChemist is referring to separation into single displaced supercells and random ones. This is a feature that might be useful for the phonon part

QuantumChemist commented 1 week ago

I think @QuantumChemist is referring to separation into single displaced supercells and random ones. This is a feature that might be useful for the phonon part

I mean this here. For now, one can only do the fit separately for single-atom-displaced, rattled supercells and the combined dataset for GAP: All the other MLIP can only use the combined dataset.

vlderinger commented 1 week ago

Ah! Yes it seems to me to make sense to let the user combine datasets, and to choose their MLIP framework, and to do both of these things independently from one another. (But not needed urgently I think)