autopkg / novaksam-recipes

JSS Autopkg recipes
Apache License 2.0
12 stars 23 forks source link

Fix for Brackets app bundle versioning #100

Open camguise opened 11 months ago

camguise commented 11 months ago

Since Brackets was taken over / forked from Adobe it appears the the new repository maintainers/developers have been publishing new versions of the app but are not updating the CFBundleShortVersionString inside the Info.plist. The current value for CFBundleShortVersionString is 1.14.2 even though the current published version of the app on Github is 2.2.0 (not including Windows only release). The Brackets download recipe pulls down the correct version but the pkg recipe is relying on the Info.plist when building a pkg file. By removing the AppDmgVersioner processor and leaving just a simple AppPkgCreator on its own the correct version string from Github will be used for both the package receipts and the pkg file name.

I have tested this recipe in my own workflow and can confirm that I'm now getting a newly packaged version with the correct file name and package receipts created (see screenshot below from Suspicious Package). Unfortunately the app still has the wrong value set for the version string but this can't be fixed without breaking the signature. There is a recent issue logged against the Brackets Github repo for this version mismatch and it sounds like they are looking to fix this issue but the changes I have made to this recipe will still continue to work even if the version number issue is resolved by the developers.

Screenshot 2023-09-26 at 1 50 09 PM