auviitkgp / kraken_3.0

Source code of Team AUV, IIT Kharagpur
http://auviitkgp.github.io
BSD 3-Clause Clear License
39 stars 58 forks source link

Change the IMU message type to Sensor_msgs/Imu #100

Closed icyflame closed 8 years ago

icyflame commented 8 years ago

@prudhvid @nevinvalsaraj Opinions on the above procedure?

cc @auviitkgp/developers

nevalsar commented 8 years ago

Rather than making a second IMU topic with the desired data format, I'd say replace the original. We have way too many original topic + converter package + modified topic clusters written as it is. Seems like a waste of transport and processing power.

icyflame commented 8 years ago

@nevinvalsaraj I am afraid that completely replacing the old topic will cause unnecessary issues with old packages. And we should rather go for this kind of a migration procedure, with a pre-set date for the removal of the old topic entirely. (say 1 month from now, leading to around 4-5 pool testing days)

nevalsar commented 8 years ago

@icyflame That's fine. We can phase out the old topic, but my point being that this needs to be done rather than keeping both of them side-by-side. :+1:

icyflame commented 8 years ago

Yes, @nevinvalsaraj . Actually, this also needs to be done for some older packages. Me and @prudhvid had decided that we would move all such packages into an obsolete/ folder. (Such as nqDvl CPP package, trax IMU, etc).