search

auviitkgp / kraken_3.0

Source code of Team AUV, IIT Kharagpur
http://auviitkgp.github.io
BSD 3-Clause Clear License
39 stars 58 forks source link

Changes in thruster mapping not compatible with simulator. Patch required to take this as a CL argument. #107

Open aniket11bh opened 8 years ago

aniket11bh commented 8 years ago

Why have you changed the thruster mappings ?

screenshot from 2016-03-21 21 41 21

icyflame commented 8 years ago

@aniket11bh Apparently, it made PID work. I think this was during december testing, is it not working now? I remember thruster mappings were repeatedly changed during winter. @kalyan-kumar Remember anything from then?

aniket11bh commented 8 years ago

The changed mapping is not suitable with the simulators, the previous one is.

On Mon, Mar 21, 2016 at 9:59 PM, Siddharth Kannan notifications@github.com wrote:

@aniket11bh https://github.com/aniket11bh Apparently, it made PID work. I think this was during december testing, is it not working now? I remember thruster mappings were repeatedly changed during winter. @kalyan-kumar https://github.com/kalyan-kumar Remember anything from then?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/auviitkgp/kraken_3.0/issues/107#issuecomment-199367034

Aniket Bhushan 3rd year Undergraduate , Manufacturing Science and Engineering IIT Kharagpur

icyflame commented 8 years ago

Hmm, that is a problem. Why not send a patch that takes a CLI argument to decide the thruster mapping? (Default will be the vehicle one of course, but just in case we want to run the simulator, we can pass in something like simulator after ./bin/exec-name.)