search

ava-labs / teleporter-token-bridge

Token bridging cross-chain built on top of Teleporter
Other
10 stars 4 forks source link

Add unit and e2e tests for separate fee changes #112

Closed minghinmatthewlam closed 3 weeks ago

minghinmatthewlam commented 3 weeks ago

Context and scope This PR https://github.com/ava-labs/teleporter-token-bridge/pull/109 adds a change to allow separate fee addresses for each token send, but only has the goal of getting existing tests passing, and we need additional unit/e2e tests.

Discussion and alternatives Add new unit tests that makes sure all 4 contracts and send/sendAndCall basic messages successfully with a different asset. Add new unit tests for ERC20Source/NativeTokenSource to check when the destination bridge uses a different fee asset, multi-hop works fine by always defaulting to the token being bridged for the intermediate step.

Add similar e2e tests.

minghinmatthewlam commented 3 weeks ago

closing in favor of adding tests direclty to #109