search

awcodes / filament-table-repeater

A modified version of the Filament Forms Repeater to display it as a table.
MIT License
188 stars 42 forks source link

Observe markedAsRequired for headers #59

Closed margarizaldi closed 11 months ago

awcodes commented 11 months ago

Can you give me a use case of this?

I'm not following the logic. If a field is already required, what effect does isMarkedAsRequired have. In what condition would isRequired be true but isMarkedAsRequired be false?

margarizaldi commented 11 months ago

Can you give me a use case of this?

I'm referring to this doc: https://filamentphp.com/docs/3.x/forms/fields/getting-started#marking-a-field-as-required

Some of us might not be happy to have asterisks in their table headers, especially if all fields are required.

On the other side, although using an asterisk for a required field is a common practice, there's no strict rule to do that.

awcodes commented 11 months ago

Fair enough. I'll get this merged soon. Thanks.