Closed Log1x closed 4 months ago
How much trouble would it be to have it default to the DefaultProfile
but allow passing an array of profiles for it to be added to?
Shouldn't be an issue. Will push an update soon!
Sorry. I pushed some changes that are going to conflict with this. My fault. Should have waited on you.
Sorry. I pushed some changes that are going to conflict with this. My fault. Should have waited on you.
No problem. I'm almost done with the implementation and I'll fix the conflicts.
everything is done and should be working. could alternatively use Arr::wrap()
on the getters and allow the profiles to be a string on the property instead of my is_string
check in the setters. Let me know if you want that changed at all. Might be better to do it this way so closures can be strings too.
otherwise, profiles can be passed as a class string or an array of classes.
Awesome. I appreciate it.
I do think Arr:wrap() would be cleaner.
I do think Arr:wrap() would be cleaner.
agreed. will push the change momentarily.
done
Thank you for your work on this. It will be in the next release.
I didn't want you to have to do it again because I keep creating conflicts for you. LOL.
I have tagged this in the PR to make sure you still get credit.
This adds support for adding tools to profiles as bubble, suggestion, or toolbar by default.
Alternatively, I can change this to only affect
DefaultProfile
instead if needed (kinda leaning towards it, would also be less code).This paired with #37 should hopefully improve DX when getting started making changes/generated tools take effect immediately.
From personal experience, I sort of feel like
->suggestionTool()
should be default in the tool generation stub(s).Another thing to consider would be maybe dropping the
Tool
suffix on the methods.