search

awkward / Tatsi

A drop-in replacement for UIImagePickerController with the ability to select multiple images and/or videos
MIT License
110 stars 30 forks source link

iOS 13 Memory Issue #31

Open AvdLee opened 4 years ago

AvdLee commented 4 years ago

We can see a crash in our crash reports regarding Memory, happening in the AssetsGridViewController and 100% on iOS 13.

We still need to look into it but I have the feeling that this is caused by loading the previews for the first time, filling up the memory.

Any ideas?

terhechte commented 4 years ago

@AvdLee Did you ever find a solution for this Antoine?

AvdLee commented 4 years ago

in our app it turned out to be related to another retain cycle as we didn't capture the new drag down dismiss for the new iOS 13 sheet presentation style.

I'm not entirely sure whether the original description is still an issue. Do you experience the same?

terhechte commented 4 years ago

No, I was pondering using this library as most of the other open source solutions for multi-selection of images did not meet my requirements. However I've started using it now and so far it looks good. :)

AvdLee commented 4 years ago

@terhechte awesome! Yeah, we're using it in the WeTransfer app and it has since not let us down 🙂