search

awkward / Tatsi

A drop-in replacement for UIImagePickerController with the ability to select multiple images and/or videos
MIT License
110 stars 30 forks source link

Added Custom checkmark color #49

Closed aadjemonkeyrock closed 3 years ago

aadjemonkeyrock commented 4 years ago

Extended the color options to also manipulate the 'selected' image checkmark.

aadjemonkeyrock commented 4 years ago

I've implemented all the suggested changes, but I'm not sure if it's what we want. For people using an older version the TatsiColors protocol has changed. If they have customized colors they need to make an adjustment. Hearing your comments that is not the behaviour that we want.

Looking at this again, it would for me already be a huge step forward if instead of the special checkmark color the checkmark uses the 'link' color from the TatsiColors. In the current implementation it always uses the 'default' supplied, but by removing the 'checkMark' color as I implemented and replace this with the 'link' color it would be a simpler solution that would not bread any compatibility, because it's not necessary to change the TatsiColors protocol.

renssies commented 3 years ago

@aadjemonkeyrock Sorry again for a very late reply! I'm about to merge the pull request and make some changes to keep compatibility for users :)