aws-ia / terraform-aws-iam-identity-center

Apache License 2.0
16 stars 6 forks source link

Incompatibility with usernames with special characters #44

Closed josesolisrosales closed 3 days ago

josesolisrosales commented 3 days ago

It is mentioned extensively throughout the documentation that:

Ensure that the name of your object(s) match the name of your principal(s) (e.g. user name or group name). 
See the following example with object/principal names 'Admin' and 'nuzumaki':

Meanining groups and users (and I am assuming this also applies to existing users and existing groups based on the error I am getting) have to be defined like so:

  sso_groups = {
    Admin : {
      group_name        = "Admin"
      group_description = "Admin IAM Identity Center Group"
    },
  }

Some organizations (ours included) use email as username for example user@organization.com. Since it includes special characters it makes it incompatible with this module as the following is not valid because of the special characters:

  existing_sso_users = {
    user.organization@organization.com = {
      user_name = "user.organization@organization.com"
    }
  }

@novekm Do you know if this is something that's been considered or any recomendations other than modifying the user mapping? (which for us would still be a problem as our users are firstname.lastname)

josesolisrosales commented 3 days ago

I've embarrased myself, one can just use double quotes to enclose the special character string in the object identifier. Sorry for the noise.