search

aws-samples / aws-eda-slurm-cluster

AWS Slurm Cluster for EDA Workloads
MIT No Attribution
24 stars 7 forks source link

[BUG] Deployment fails if submitter security groups not configured #191

Closed cartalla closed 6 months ago

cartalla commented 6 months ago

Describe the bug

Deployment failed when trying to create minimal cluster with no other assets in the VPC. There are no SOCA or RES desktop instances so submitter security groups weren't configured and I got the following traceback.

Traceback (most recent call last):
  File "app.py", line 32, in <module>
    termination_protection = True,
  File "/workplace/cartalla/github/aws-eda-slurm-cluster/source/.venv/lib64/python3.7/site-packages/jsii/_runtime.py", line 118, in __call__
    inst = super(JSIIMeta, cast(JSIIMeta, cls)).__call__(*args, **kwargs)
  File "/workplace/cartalla/github/aws-eda-slurm-cluster/source/cdk/cdk_slurm_stack.py", line 132, in __init__
    self.create_parallel_cluster_assets()
  File "/workplace/cartalla/github/aws-eda-slurm-cluster/source/cdk/cdk_slurm_stack.py", line 586, in create_parallel_cluster_assets
    string_value = self.configure_submitters_sns_topic.topic_arn
AttributeError: 'CdkSlurmStack' object has no attribute 'configure_submitters_sns_topic'
cartalla commented 6 months ago

Resolved by #192