Closed aismann closed 1 year ago
Use commit-hash is better
Use commit-hash is better
What aver you mean is better as the current implementation (its not updated)
maybe some of this question can also be get "during runtime"?
- axmol version:
- devices test on:
- developing environments
- NDK version: r19c
- Xcode version: 12.4
- Visual Studio:
- VS version: 2019 (16.11), 2022 (17.4)
- MSVC version: 1929, 1934
- Windows SDK version: 10.0.22621.0
- cmake version:
Steps to Reproduce:
@halx99 its your "cmake" turn?
@halx99 The changes in https://github.com/axmolengine/axmol/commit/ee2de093a71ead88c2de6f914b4ce517849eb7be are picking up the .git of the game project, and not the .git in the axmol folder. The results in the version.h file contain the git build, branch and commit hashes of the game project.
Is there something I need to set in order to get it working correctly?
Never mind! Found out what was causing the issue. The changes in PR #1149 seem to work.
@halx99 please add a a "hardcoded" PR like this?
example: