axmolengine / axmol

Axmol Engine – A Multi-platform Engine for Desktop, XBOX (UWP) and Mobile games. (A fork of Cocos2d-x-4.0)
https://axmol.dev
MIT License
922 stars 205 forks source link

Error (with fix): OpenAL having compilation issues. #1144

Closed TheNachoBIT closed 1 year ago

TheNachoBIT commented 1 year ago

Axmol Version: Release


Hello! I had this issue where the OpenAL build finds the OSS, but its the Clang version of it, and MSVC doesn't have such thing as OSS.

I reported this issue in here along with a solution, where i go in much more detail (also saying that the error was discovered & fixed in Axmol Engine): https://github.com/kcat/openal-soft/issues/839

I'm not sending any PRs because this is probably a duck-tape solution, and also this project probably has a heavily modified version of OpenAL, but this issue happens on both Axmol's OpenAL and the OG OpenAL, both fixed with the same solution.

Hope this helps :)

rh101 commented 1 year ago

I can't reproduce this issue. MSYS2/Clang are installed on my system, and not once has there been a problem with MSVC detecting OSS or any other strange issues like that. Are you sure this isn't something specific to your setup (such as environment paths etc.)?

rh101 commented 1 year ago

This issue was apparently addressed in this commit: https://github.com/kcat/openal-soft/commit/3e4a2a151860c04fb0ebb971343a6f05e0c3c08a

halx99 commented 1 year ago

should fixed by https://github.com/axmolengine/axmol/commit/dfa87703ca707b9b6a7d11e83310dcac42d5d9a9