DrawNode calls: replacing Color4F with Color4B (without the 'test' folder!) - Githubissues

axmolengine / axmol

Axmol Engine – A Multi-platform Engine for Desktop, XBOX (UWP) and Mobile games. (A fork of Cocos2d-x-4.0)

https://axmol.dev

MIT License

929 stars 205 forks source link

DrawNode calls: replacing Color4F with Color4B (without the 'test' folder!) #2192

Closed aismann closed 1 month ago

aismann commented 1 month ago

Describe your changes

Should be a small performance hub See also axmol-1.0.0 Aug.9 2023: [REFINE] Change DrawNode api color parameters from Color4F to low Color4B

Issue ticket number and link

Checklist before requesting a review

For each PR

[ ] Add Copyright if it missed:
- "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
[x] I have performed a self-review of my code.

Optional:
- [ ] I have checked readme and add important infos to this PR.
- [ ] I have added/adapted some tests too.

For core/new feature PR

[ ] I have checked readme and add important infos to this PR.
[ ] I have added thorough tests.

halx99 commented 1 month ago

but we may change underlaying color to vec4 in the future release

aismann commented 1 month ago

but we may change underlaying color to vec4 in the future release

The PR is for the current implementation.

@halx99 will you accept this PR? If not I will make an own PR for the 'removed unused includes' stuff.

halx99 commented 1 month ago

both Color4F and Color4B is lgtm currently, I will merge it now, let me check